Arvados

Nico César wrote:

review at 984703527b7205372d28a9c27e8356986d3ba278

Is the intention the rake task import_vscode_training from time to time to sync up the content of our repo when https://github.com/arvados/arvados-vscode-cwl-training gets updated? if so, that part looks good to me and I think is ready to merge to Arvados Repo.

about the content of the training, this are my open questions:

there are many references to Windows only install (like /c/Users/MyUsername/.ssh/id_rsa.pub), shall we add a Note that this is Windows only or shall we expand to other operating systems?

I tweaked the text a bit to clarify which instructions are Windows only and which apply to any OS. There's really very little that is Windows specific.

Step 1.3.iv (see screenshot) could be confusing if no shell nodes are available.

I'm assuming that users have access to shell nodes, because otherwise none of the rest of the instructions work as written. If you are on Linux and have the Arvados Python SDK installed most of the instructions could still apply, I'm assuming Linux users are more likely to be able to figure that out on their own.

We should add notes/screenshot of what to expect. Since users can be doing a lot of steps but is something looks fishy should be pointed out.

I did that with some of the VSCode icons, although not with Workbench 2. Screenshots can go stale very quickly when the thing you are documenting changes a lot. I'm also not sure where people are most likely to get stuck and need extra visual help. I'm open to suggestions but I'd like to get to merging as-is so that I can send Roche a link to the page as displayed on our documentation site instead of it being a separate github repo.

in 1.3 there could be a bug related to wb2 and admins (or maybe users too...) See Bug #17357

section 2.6 shouldn't be labled "Go to Arvados Workbench" since there is a back and forth from wb to vscode

I would add:
3.1.iv -> "WORKFLOW_UUID should appear in the directory. You can double check your submission on workbench searching for that UUID"

Nico César wrote:

Step 2.4 forced me to uninstall and install the extension. See 3 screenshots

Shouldn't be necessary to uninstall. You do need to install it on the remote host, if for some reason you installed it locally, that isn't totally obvious, so I added a note.

Nico César wrote:

in 1.3 there could be a bug related to wb2 and admins (or maybe users too...) See Bug #17357

You're right, that's a bug, but that is out of scope for this story, most people doing this won't be admins.

Nico César wrote:

section 2.6 shouldn't be labled "Go to Arvados Workbench" since there is a back and forth from wb to vscode

Right, that's a little confusing, I adjusted the text and order a bit.

I would add:
3.1.iv -> "WORKFLOW_UUID should appear in the directory. You can double check your submission on workbench searching for that UUID"

I added a note about the file showing up. I didn't get into what the contents of the file means, the user doesn't need to know all the details.

17165-vscode-training-doc @ 5ccc1a94d1621e319990a4362c131d5ab776c478

5ccc1a94d1621e319990a4362c131d5ab776c478

LGTM, we can always improve later (and re-create a arvados repo merge.)