Bug #17199
[tests] Avoid random port conflicts when bringing up integration test services
100%
Description
Occasionally this code in source:sdk/python/tests/run_test_server.py chooses the same port twice, which causes the test suite to fail:
def setup_config():
rails_api_port = find_available_port()
controller_port = find_available_port()
controller_external_port = find_available_port()
websocket_port = find_available_port()
websocket_external_port = find_available_port()
workbench1_port = find_available_port()
workbench1_external_port = find_available_port()
# ...
Subtasks
Associated revisions
History
#1
Updated by Tom Clegg over 1 year ago
17199-available-port-race @ 3083521d8b6c83b0d80e4f63c56ee434ad8fa697 -- developer-run-tests: #2210
#2
Updated by Ward Vandewege over 1 year ago
Tom Clegg wrote:
17199-available-port-race @ 3083521d8b6c83b0d80e4f63c56ee434ad8fa697 -- developer-run-tests: #2210
LGTM. Of course it won't protect against port numbers being reused accidentally when running multiple copies of run_test_server.py on the same machine...
#3
Updated by Tom Clegg over 1 year ago
port numbers being reused accidentally when running multiple copies of run_test_server.py on the same machine...
Indeed, reliably avoiding that would be a different story...
#4
Updated by Anonymous over 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|b43a1bccda8980c6fcb9b3fbaad36b986c472028.
#5
Updated by Peter Amstutz 6 months ago
- Release set to 41
Merge branch '17199-available-port-race'
fixes #17199
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@tomclegg.ca>