Bug #17199

[tests] Avoid random port conflicts when bringing up integration test services

Added by Tom Clegg 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Tests
Target version:
2020-12-16 Sprint
Start date:
12/08/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Occasionally this code in source:sdk/python/tests/run_test_server.py chooses the same port twice, which causes the test suite to fail:

def setup_config():
    rails_api_port = find_available_port()
    controller_port = find_available_port()
    controller_external_port = find_available_port()
    websocket_port = find_available_port()
    websocket_external_port = find_available_port()
    workbench1_port = find_available_port()
    workbench1_external_port = find_available_port()
    # ...

Subtasks

Task #17201: Review 17199-available-port-raceResolvedWard Vandewege

Associated revisions

Revision b43a1bcc
Added by Tom Clegg 10 months ago

Merge branch '17199-available-port-race'

fixes #17199

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#2 Updated by Ward Vandewege 10 months ago

Tom Clegg wrote:

17199-available-port-race @ 3083521d8b6c83b0d80e4f63c56ee434ad8fa697 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/2210/

LGTM. Of course it won't protect against port numbers being reused accidentally when running multiple copies of run_test_server.py on the same machine...

#3 Updated by Tom Clegg 10 months ago

port numbers being reused accidentally when running multiple copies of run_test_server.py on the same machine...

Indeed, reliably avoiding that would be a different story...

#4 Updated by Anonymous 10 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF