Project

General

Profile

Actions

Bug #17204

closed

[keep-web] Avoid red-herring error log on 304 Not Modified responses

Added by Tom Clegg almost 4 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Story points:
-
Release relationship:
Auto

Description

While handling a conditional request that results in a 304 Not Modified response, keep-web logs this error:

"stat.Size()==3299929 but only wrote 0 bytes; read(1024) returns 1024, %!s(<nil>)" 
We should
  1. use %v instead of %s so a nil error is just "nil" instead of "%!s(<nil>)"
  2. not log this error if the response code is 304

Subtasks 1 (0 open1 closed)

Task #17553: Review 17204-not-modifiedResolvedTom Clegg04/21/2021Actions
Actions #1

Updated by Tom Clegg almost 4 years ago

  • Description updated (diff)
Actions #2

Updated by Tom Clegg over 3 years ago

  • Target version set to 2021-04-28 bughunt sprint
  • Assigned To set to Tom Clegg
Actions #3

Updated by Tom Clegg over 3 years ago

  • Status changed from New to In Progress

17204-not-modified @ 17a35d4e667e2c38b5c00c174bd9a76e784ebaef -- developer-run-tests: #2434

The test covers the 304 case, but the fix covers other non-200 response codes as well, like 412 precondition failed and 207 partial content.

Also fixed an unclosed-file bug, even though (so far) it was harmless because Close() is a no-op in a collectionfs.

Actions #5

Updated by Tom Clegg over 3 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #6

Updated by Peter Amstutz almost 3 years ago

  • Release set to 41
Actions

Also available in: Atom PDF