Bug #17204

[keep-web] Avoid red-herring error log on 304 Not Modified responses

Added by Tom Clegg over 1 year ago. Updated 6 months ago.

Assigned To:
Start date:
Due date:
% Done:


Estimated time:
(Total: 0.00 h)
Story points:
Release relationship:


While handling a conditional request that results in a 304 Not Modified response, keep-web logs this error:

"stat.Size()==3299929 but only wrote 0 bytes; read(1024) returns 1024, %!s(<nil>)" 
We should
  1. use %v instead of %s so a nil error is just "nil" instead of "%!s(<nil>)"
  2. not log this error if the response code is 304


Task #17553: Review 17204-not-modifiedResolvedTom Clegg

Associated revisions

Revision 7141824b
Added by Tom Clegg about 1 year ago

Merge branch '17204-not-modified'

fixes #17204

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>


#1 Updated by Tom Clegg over 1 year ago

  • Description updated (diff)

#2 Updated by Tom Clegg about 1 year ago

  • Target version set to 2021-04-28 bughunt sprint
  • Assigned To set to Tom Clegg

#3 Updated by Tom Clegg about 1 year ago

  • Status changed from New to In Progress

17204-not-modified @ 17a35d4e667e2c38b5c00c174bd9a76e784ebaef -- developer-run-tests: #2434

The test covers the 304 case, but the fix covers other non-200 response codes as well, like 412 precondition failed and 207 partial content.

Also fixed an unclosed-file bug, even though (so far) it was harmless because Close() is a no-op in a collectionfs.

#5 Updated by Tom Clegg about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#6 Updated by Peter Amstutz 6 months ago

  • Release set to 41

Also available in: Atom PDF