Project

General

Profile

Actions

Bug #17204

closed

[keep-web] Avoid red-herring error log on 304 Not Modified responses

Added by Tom Clegg over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Story points:
-
Release relationship:
Auto

Description

While handling a conditional request that results in a 304 Not Modified response, keep-web logs this error:

"stat.Size()==3299929 but only wrote 0 bytes; read(1024) returns 1024, %!s(<nil>)" 
We should
  1. use %v instead of %s so a nil error is just "nil" instead of "%!s(<nil>)"
  2. not log this error if the response code is 304

Subtasks 1 (0 open1 closed)

Task #17553: Review 17204-not-modifiedResolvedTom Clegg04/21/2021Actions
Actions

Also available in: Atom PDF