Project

General

Profile

Actions
Copy link

Bug #17256

closed

File selection dialog does not expand more than one level

Added by Peter Amstutz almost 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Daniel Kutyła
Category:
Workbench2
Target version:
2021-02-03 Sprint
Start date:
01/15/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.2.2
Release relationship:
Auto

Description

Steps to reproduce:

  1. Go to +NEW → Run a process
  2. Pick a CWL workflow with a File type input
  3. Click on the file input
  4. A dialog box will appear to choose a file
  5. Expand "Projects"
  6. Subprojects and collections will appear but you are unable to expand any of them in order to be able to select a file.

Subtasks 1 (0 open — 1 closed)

Task #17259: ReviewResolvedPeter Amstutz01/15/2021

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Peter Amstutz almost 3 years ago

  • Assigned To set to Daniel Kutyła
Actions
Copy link
 #4

Updated by Peter Amstutz almost 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Peter Amstutz almost 3 years ago

Daniel Kutyła wrote:

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d9438b97a2ca16ee35a93e54a5bdd1312ea65fbe
Test run: developer-tests-workbench2: #2 ​46/

Code optimisation

This looks good, as suggested in chat, let's add at an integration test that opens the tree picker and navigates at least 3 levels down.

Actions
Copy link
 #8

Updated by Peter Amstutz almost 3 years ago

Please go ahead and merge the fix and then follow up with a test branch.

Actions
Copy link
 #9

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint
Actions
Copy link
 #11

Updated by Lucas Di Pentima almost 3 years ago

I've made a branch updating nodejs to version 10.x: 4248a4e at 17256-nodejs-dependency-update

Updates:
  • Changes lib/install/deps.go to ask for node 10.23.1 instead of 8.15.1
  • Changes build/package-build-dockerfiles/Makefile to download the newer nodejs.
  • Changes build/package-build-dockerfiles/*/Dockerfile to use the downloaded nodejs version.
  • Updates a message on run-tests.sh when no nodejs is found.
Things I've tried:
Actions
Copy link
 #12

Updated by Lucas Di Pentima almost 3 years ago

Merged wb2's newest master into 17256-File-selection-dialog-browser-tests at arvados-workbench2|4f87358 so that it has the latest Dockerfile.
Test run: developer-tests-workbench2: #251

Actions
Copy link
 #15

Updated by Daniel Kutyła almost 3 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #16

Updated by Peter Amstutz about 2 years ago

  • Release set to 41
Actions
Copy link

Also available in: Atom PDF