Bug #17256

File selection dialog does not expand more than one level

Added by Peter Amstutz 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/15/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Steps to reproduce:

  1. Go to +NEW → Run a process
  2. Pick a CWL workflow with a File type input
  3. Click on the file input
  4. A dialog box will appear to choose a file
  5. Expand "Projects"
  6. Subprojects and collections will appear but you are unable to expand any of them in order to be able to select a file.

Subtasks

Task #17259: ReviewResolvedPeter Amstutz

Associated revisions

Revision 80dbda89
Added by Lucas Di Pentima 9 months ago

Merge branch '17256-nodejs-dependency-update'
Refs #17256

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

Revision d33e5d82 (diff)
Added by Lucas Di Pentima 9 months ago

Updates the Dockefile to request a newer nodejs base image.
Refs #17256

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

Revision d01d7f3a
Added by Daniel Kutyła 9 months ago

Merge branch '17256-File-selection-dialog-browser-tests'
closes #17256

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 9 months ago

  • Assigned To set to Daniel Kutyła

#4 Updated by Peter Amstutz 9 months ago

  • Status changed from New to In Progress

#7 Updated by Peter Amstutz 9 months ago

Daniel Kutyła wrote:

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d9438b97a2ca16ee35a93e54a5bdd1312ea65fbe
Test run: https://ci.arvados.org/job/developer-tests-workbench2/2​46/

Code optimisation

This looks good, as suggested in chat, let's add at an integration test that opens the tree picker and navigates at least 3 levels down.

#8 Updated by Peter Amstutz 9 months ago

Please go ahead and merge the fix and then follow up with a test branch.

#9 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint

#11 Updated by Lucas Di Pentima 9 months ago

I've made a branch updating nodejs to version 10.x: 4248a4e at 17256-nodejs-dependency-update

Updates:
  • Changes lib/install/deps.go to ask for node 10.23.1 instead of 8.15.1
  • Changes build/package-build-dockerfiles/Makefile to download the newer nodejs.
  • Changes build/package-build-dockerfiles/*/Dockerfile to use the downloaded nodejs version.
  • Updates a message on run-tests.sh when no nodejs is found.
Things I've tried:

#12 Updated by Lucas Di Pentima 9 months ago

Merged wb2's newest master into 17256-File-selection-dialog-browser-tests at arvados-workbench2|4f87358 so that it has the latest Dockerfile.
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/251/

#15 Updated by Daniel Kutyła 9 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF