Bug #17256
File selection dialog does not expand more than one level
100%
Description
Steps to reproduce:
- Go to +NEW → Run a process
- Pick a CWL workflow with a File type input
- Click on the file input
- A dialog box will appear to choose a file
- Expand "Projects"
- Subprojects and collections will appear but you are unable to expand any of them in order to be able to select a file.
Subtasks
Associated revisions
Updates the Dockefile to request a newer nodejs base image.
Refs #17256
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>
Merge branch '17256-File-selection-dialog-browser-tests'
closes #17256
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>
History
#1
Updated by Peter Amstutz 3 months ago
- Description updated (diff)
#2
Updated by Peter Amstutz 3 months ago
- Description updated (diff)
#3
Updated by Peter Amstutz 3 months ago
- Assigned To set to Daniel Kutyła
#4
Updated by Peter Amstutz 3 months ago
- Status changed from New to In Progress
#5
Updated by Daniel Kutyła 3 months ago
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/c859c9d9325e2ed86d5d7b067e1209e73ee81251
Test run: https://ci.arvados.org/job/developer-tests-workbench2/243/
Added map that allows to fetch tree item by its id
#6
Updated by Daniel Kutyła 3 months ago
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d9438b97a2ca16ee35a93e54a5bdd1312ea65fbe
Test run: https://ci.arvados.org/job/developer-tests-workbench2/246/
Code optimisation
#7
Updated by Peter Amstutz 3 months ago
Daniel Kutyła wrote:
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d9438b97a2ca16ee35a93e54a5bdd1312ea65fbe
Test run: https://ci.arvados.org/job/developer-tests-workbench2/246/Code optimisation
This looks good, as suggested in chat, let's add at an integration test that opens the tree picker and navigates at least 3 levels down.
#8
Updated by Peter Amstutz 3 months ago
Please go ahead and merge the fix and then follow up with a test branch.
#9
Updated by Peter Amstutz 3 months ago
- Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint
#10
Updated by Daniel Kutyła 3 months ago
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/746ddef70989e802ec52e244033ccd3b8c51f60e
Test run: https://ci.arvados.org/job/developer-tests-workbench2/248/
Browser tests
#11
Updated by Lucas Di Pentima 3 months ago
I've made a branch updating nodejs
to version 10.x: 4248a4e at 17256-nodejs-dependency-update
- Changes
lib/install/deps.go
to ask for node 10.23.1 instead of 8.15.1 - Changes
build/package-build-dockerfiles/Makefile
to download the newer nodejs. - Changes
build/package-build-dockerfiles/*/Dockerfile
to use the downloaded nodejs version. - Updates a message on
run-tests.sh
when no nodejs is found.
- Created a docker image to run wb2 integration tests with node-v10.x & Cypress v6.x
- Ran a Jenkins test pipeline: https://ci.arvados.org/job/developer-run-tests/2273/
- Re-running wb integration tests: https://ci.arvados.org/job/developer-run-tests-apps-workbench-integration/2409/
- Ran the package build scripts
#12
Updated by Lucas Di Pentima 3 months ago
Merged wb2's newest master into 17256-File-selection-dialog-browser-tests
at arvados-workbench2|4f87358 so that it has the latest Dockerfile.
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/251/
#13
Updated by Daniel Kutyła 3 months ago
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/0b4bf78868000b7ed29570b56581a24ff671f49c
Test run: https://ci.arvados.org/job/developer-tests-workbench2/253
Fixed failing browser test
#14
Updated by Peter Amstutz 3 months ago
Daniel Kutyła wrote:
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/0b4bf78868000b7ed29570b56581a24ff671f49c
Test run: https://ci.arvados.org/job/developer-tests-workbench2/253Fixed failing browser test
This LGTM.
#15
Updated by Daniel Kutyła 3 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|d01d7f3a3164e305b9bd335c118d670b7574dfde.
Merge branch '17256-nodejs-dependency-update'
Refs #17256
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>