Bug #17257

acrContainerImage not being honored consistently

Added by Peter Amstutz 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/14/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

When using Workbench 2 to create a container request from pirca-7fd4e-c2bb0z0szqdacyc the acrContainerImage field is honored.

When creating a container request from pirca-7fd4e-zkvu363nlkykwu6 it does not honor acrContainerImage, it creates the CR with arvados/jobs.

The only substantive difference I can find is that the 1st on takes a string input, the 2nd one takes a File input which has a default value.

It is particularly odd because the "Runner" field in the "Advanced" section of the form has the correct value. Somehow it is being replaced with the default "arvados/jobs" value before the container request is constructed.


Subtasks

Task #17258: Review 17257-wf-advanced-settingsResolvedPeter Amstutz

Associated revisions

Revision 4d5c42e7
Added by Peter Amstutz 3 months ago

Merge branch '17257-wf-advanced-settings' refs #17257

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

#4 Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz

#5 Updated by Peter Amstutz 3 months ago

Going to the "Workflows" panel and then clicking "Run" on a workflow followed a slightly different code path than going to "+NEW" and "Run a process". This needed to call getWorkflowRunnerSettings() to initialize the "advanced" fields correctly.

17257-wf-advanced-settings @ arvados-workbench2|eb618fd2317411f11d40230e140e60917342a0a9

https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/242/

#6 Updated by Peter Amstutz 3 months ago

  • Status changed from New to In Progress

#7 Updated by Lucas Di Pentima 3 months ago

Just one nit:

  • I think we could un-export the constant at src/store/run-process-panel/run-process-panel-actions.ts Line 189 now that it isn't used anywhere else.

Otherwise LGTM, thanks!

#8 Updated by Peter Amstutz 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF