Project

General

Profile

Actions

Bug #17257

closed

acrContainerImage not being honored consistently

Added by Peter Amstutz over 3 years ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Description

When using Workbench 2 to create a container request from pirca-7fd4e-c2bb0z0szqdacyc the acrContainerImage field is honored.

When creating a container request from pirca-7fd4e-zkvu363nlkykwu6 it does not honor acrContainerImage, it creates the CR with arvados/jobs.

The only substantive difference I can find is that the 1st on takes a string input, the 2nd one takes a File input which has a default value.

It is particularly odd because the "Runner" field in the "Advanced" section of the form has the correct value. Somehow it is being replaced with the default "arvados/jobs" value before the container request is constructed.


Subtasks 1 (0 open1 closed)

Task #17258: Review 17257-wf-advanced-settingsResolvedPeter Amstutz01/14/2021Actions
Actions #1

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz over 3 years ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz over 3 years ago

Going to the "Workflows" panel and then clicking "Run" on a workflow followed a slightly different code path than going to "+NEW" and "Run a process". This needed to call getWorkflowRunnerSettings() to initialize the "advanced" fields correctly.

17257-wf-advanced-settings @ arvados-workbench2|eb618fd2317411f11d40230e140e60917342a0a9

developer-tests-workbench2: #242

Actions #6

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions #7

Updated by Lucas Di Pentima over 3 years ago

Just one nit:

  • I think we could un-export the constant at src/store/run-process-panel/run-process-panel-actions.ts Line 189 now that it isn't used anywhere else.

Otherwise LGTM, thanks!

Actions #8

Updated by Peter Amstutz over 3 years ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz about 2 months ago

  • Release set to 37
Actions

Also available in: Atom PDF