Bug #17264

Files in file picker have wrong icon (folder instead of file)

Added by Peter Amstutz 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/21/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #17265: ReviewClosedDaniel Kutyła

Associated revisions

Revision 90e5ed1b
Added by Daniel Kutyła 9 months ago

Merge branch '17264-Files-in-file-picker-have-wrong-icon'
closes #17264

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Assigned To set to Daniel Kutyła

#2 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint

#3 Updated by Daniel Kutyła 9 months ago

  • Status changed from New to In Progress

#4 Updated by Daniel Kutyła 9 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/534df712c4cfc3f6574dee1f4906bb7f6cc70be9
Test run: https://ci.arvados.org/job/developer-tests-workbench2/2​49/

This is the simplest yet the fastest way to implement this, I would vote for a cleanup ticket for the tree components all over the app as this is really messy.

#5 Updated by Peter Amstutz 9 months ago

I noticed that CollectionIcon and FileIcon use the same "LibraryBooks" material ui icon. Let's change what FileIcon uses. I think the one from the material UI icons that works best is the Description icon. Could you make this change?

workbench2/src/components/icon/icon.tsx

export const FileIcon: IconType = (props) => <Description {...props} />;

LGTM with that tweak.

#6 Updated by Daniel Kutyła 9 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Also available in: Atom PDF