Actions
Bug #17264
closed
Files in file picker have wrong icon (folder instead of file)
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Updated by Peter Amstutz over 3 years ago
- Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint
Updated by Daniel Kutyła over 3 years ago
- Status changed from New to In Progress
Updated by Daniel Kutyła over 3 years ago
New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/534df712c4cfc3f6574dee1f4906bb7f6cc70be9
Test run: developer-tests-workbench2: #2 49/
This is the simplest yet the fastest way to implement this, I would vote for a cleanup ticket for the tree components all over the app as this is really messy.
Updated by Peter Amstutz about 3 years ago
I noticed that CollectionIcon and FileIcon use the same "LibraryBooks" material ui icon. Let's change what FileIcon uses. I think the one from the material UI icons that works best is the Description icon. Could you make this change?
workbench2/src/components/icon/icon.tsx
export const FileIcon: IconType = (props) => <Description {...props} />;
LGTM with that tweak.
Updated by Daniel Kutyła about 3 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|90e5ed1bcd066cddd05fb7e1e18071f78b539a12.
Actions