Bug #17266

Properties UI allows to add custom values on strict vocabulary entries.

Added by Lucas Di Pentima 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Start date:
01/27/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When the user types a value first and then selects a property key that belongs to a "strict" vocabulary term, the value doesn't get validated and the UI allows the user to enter it as a literal.


Subtasks

Arvados - Task #17276: Review 17266-property-ui-synonym-fixResolvedDaniel KutyƂa


Related issues

Related to Arvados Workbench 2 - Bug #17308: Property editor on "new project dialog" doesn't work properly with vocabulary termsResolved02/02/2021

Associated revisions

Revision 7f551720
Added by Lucas Di Pentima 3 months ago

Merge branch '17266-property-ui-synonym-fix'
Closes #17266

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Lucas Di Pentima 3 months ago

  • Status changed from New to In Progress

#2 Updated by Lucas Di Pentima 3 months ago

  • Target version changed from 2021-01-20 Sprint to 2021-02-03 Sprint

#3 Updated by Lucas Di Pentima 3 months ago

Status update:

I've fixed several instances of the same bug at commit:arvados-workbench2|7d7a9bf - branch 17266-property-ui-synonym-fix, and also wrote an integration test that confirms it's correctly behaving.

Also added an optimization on Cypress tests that exposed a new bug that I'm trying to fix right now: when the details panel is open showing the collection version browser, sometimes renaming a collection changes the focus of the detail panel to show the collection's parent project information. This made a preexisting test fail.

#4 Updated by Lucas Di Pentima 3 months ago

Updates at arvados-workbench2|f75dc834 - branch 17266-property-ui-synonym-fix
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/263/

  • Fixed failing test described on the previous note.
  • Committed yarn.lock with the changes from updating cypress to 6.x on a previous branch.

#5 Updated by Lucas Di Pentima 3 months ago

  • Status changed from In Progress to Resolved

#6 Updated by Lucas Di Pentima 3 months ago

  • Related to Bug #17308: Property editor on "new project dialog" doesn't work properly with vocabulary terms added

#7 Updated by Lucas Di Pentima 3 months ago

  • Release set to 37

Also available in: Atom PDF