Bug #17289

Download of folders in collections should be disabled

Added by Daniel KutyƂa 4 months ago. Updated 8 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
04/28/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

When selecting "Download" from the menu next to a folder in a collection the result is that a html file is downloaded. This is the keep-web html that otherwise is displayed when selecting "Open in new tab".

Expected behaviour: A zip is created containing the folder with all nested files and subfolders. This should also reliably work on subfolders.

Workaround: The expected behaviour requires an API doing this on the server which also works for large datasets. Until this is implemented the download mechanism should be disabled for everything that is not a file.

Side note: The instructions to download collection content (keep-web HTML) contain a wget command which does not contain authentication. Without this is non-functional.


Subtasks

Task #17596: Review 17289-dir-download-action-removalResolvedPeter Amstutz

Associated revisions

Revision c0309f65
Added by Lucas Di Pentima 8 days ago

Merge branch '17289-dir-download-action-removal'
Closes #17289

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 15 days ago

  • Target version set to 2021-05-12 sprint

#2 Updated by Peter Amstutz 15 days ago

  • Assigned To set to Lucas Di Pentima

#3 Updated by Lucas Di Pentima 15 days ago

  • Status changed from New to In Progress

#4 Updated by Lucas Di Pentima 14 days ago

Updates at arvados-workbench2|beacdc4d - branch 17289-dir-download-action-removal
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/398/

  • Removes "Download" action from directories on collection files listing.
  • Adds test.

#5 Updated by Peter Amstutz 9 days ago

Reviewing 17289-dir-download-action-removal @ commit:beacdc4d38efb1880aaa14e8b3985e683d14e457

In src/views-components/context-menu/action-sets/collection-files-item-action-set.ts line 53-61 is commented out code that probably doesn't need to be there? Or a comment about why it is commented out and why you might want it later.

Rest LGTM.

#6 Updated by Lucas Di Pentima 8 days ago

Thanks, that commented-out code was other attempts that I was trying, removed and merged!

#7 Updated by Anonymous 8 days ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF