Download of folders in collections should be disabled
When selecting "Download" from the menu next to a folder in a collection the result is that a html file is downloaded. This is the keep-web html that otherwise is displayed when selecting "Open in new tab".
Expected behaviour: A zip is created containing the folder with all nested files and subfolders. This should also reliably work on subfolders.
Workaround: The expected behaviour requires an API doing this on the server which also works for large datasets. Until this is implemented the download mechanism should be disabled for everything that is not a file.
Side note: The instructions to download collection content (keep-web HTML) contain a wget command which does not contain authentication. Without this is non-functional.
#4 Updated by Lucas Di Pentima 14 days ago
Updates at arvados-workbench2|beacdc4d - branch
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/398/
- Removes "Download" action from directories on collection files listing.
- Adds test.
#5 Updated by Peter Amstutz 9 days ago
Reviewing 17289-dir-download-action-removal @ commit:beacdc4d38efb1880aaa14e8b3985e683d14e457
In src/views-components/context-menu/action-sets/collection-files-item-action-set.ts line 53-61 is commented out code that probably doesn't need to be there? Or a comment about why it is commented out and why you might want it later.
- Status changed from In Progress to Resolved
Applied in changeset arvados-workbench2|c0309f65edc9e6ed92e13d4d83afaa8b043c56b0.