Bug #17295

arvados-server config should validate cluster ids

Added by Peter Amstutz 9 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
API
Target version:
2021-03-03 sprint
Start date:
02/19/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.1.2
Release relationship:
Auto

Description

User put in an invalid cluster id (6 characters). The controller behaves very strangely when you do that. arvadso-server should validate that the cluster id is exactly 5 alphanumeric (lowercase) characters.

This should check all occurrences of cluster ids in a file (Clusters, RemoteClusters, LoginCluster, etc).

Subtasks

Task #17323: Review 17295-configured-cluster-ids-validationResolvedPeter Amstutz

Associated revisions

Revision 89a30904
Added by Lucas Di Pentima 8 months ago

Merge branch '17295-configured-cluster-ids-validation'
Closes #17295

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#4 Updated by Peter Amstutz 8 months ago

  • Assigned To set to Lucas Di Pentima

#5 Updated by Lucas Di Pentima 8 months ago

  • Target version changed from 2021-02-17 sprint to 2021-03-03 sprint

#6 Updated by Lucas Di Pentima 8 months ago

  • Status changed from New to In Progress

#7 Updated by Lucas Di Pentima 8 months ago

Fix at a4ca691 - branch 17295-configured-cluster-ids-validation
Test run: https://ci.arvados.org/job/developer-run-tests/2335/

  • Adds cluster ID validation on config loader, with tests.

#8 Updated by Peter Amstutz 8 months ago

Lucas Di Pentima wrote:

Fix at a4ca691 - branch 17295-configured-cluster-ids-validation
Test run: https://ci.arvados.org/job/developer-run-tests/2335/

  • Adds cluster ID validation on config loader, with tests.

It occurs to me that you could have an all-numeric cluster id. I think that would behave correctly.

LGTM.

#9 Updated by Anonymous 8 months ago

  • Status changed from In Progress to Resolved

#10 Updated by Peter Amstutz 8 months ago

  • Release set to 37

Also available in: Atom PDF