CommonService.get(uuid) should throw an exception when uuid is empty string
uuid is "", the service layer does a request to the backend with an incorrect URL, for example:
arvados/v1/container_requests/, ultimately getting a 404 response.
RailsAPI may accept trailing slashes on some endpoints, but as we're migrating those endpoint handlings to
controller, these kind of issues may start to creep up of different parts of the app.
#4 Updated by Lucas Di Pentima 3 months ago
Fix at arvados-workbench2|0429d378 - branch
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/293/
- Validates that
uuidis not an empty string on
- Adds unit tests.
#5 Updated by Daniel Kutyła 3 months ago
const axiosInstance = axios.create();
// const axiosMock = new MockAdapter(axiosInstance);
const commonService = new CommonService(axiosInstance, "resource", actions);
please use mock and wrap this code in the beforeEach
#7 Updated by Daniel Kutyła 3 months ago
commonService = new CommonService<any>(axiosInstance, "resource", actions); axiosInstance = axios.create();
axiosInstance = axios.create(); commonService = new CommonService<any>(axiosInstance, "resource", actions);
as on a first call axiosInstance is null, on the other hand are you sure that you want to use axios without mocking within the test file?
#8 Updated by Lucas Di Pentima 3 months ago
Updates at arvados-workbench2|0c04dddf
I've cleaned up the test code a little bit, the axios instance is created just to satisfy the
CommonService constructor, it's not being used on the test cases.
AFAICT, the axios mock would allow me to re-record test responses but in these test cases I'm not testing that, I'm just confirming that exceptions are being thrown when
uuid=="" on some service calls.
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados:arvados-workbench2|1492885f32eefc4599f4f44228a6adf2ed7b8f7f.