Feature #17389

Storage classes support in keepproxy

Added by Nico César 8 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
06/18/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Support storage classes for PUT:

  • Propagate X-Keep-Storage-Classes headed received from clients, ensure that blocks are written to the correct storage classes
  • On success, return fulfilled X-Keep-Storage-Classes-Confirmed to client

Subtasks

Task #17819: Review 17389-keepproxy-storage-classes-confirmedResolvedPeter Amstutz


Related issues

Related to Arvados Epics - Story #16107: Storage classesIn Progress03/01/202109/30/2021

Blocked by Arvados - Feature #17349: [Keep API] Revisit "replicas_desired" and "storage_classes_desired".Rejected

Associated revisions

Revision afbb3f05
Added by Lucas Di Pentima 4 months ago

Merge branch '17389-keepproxy-storage-classes-confirmed'
Closes #17389

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Nico César 8 months ago

  • Target version set to To Be Groomed

#2 Updated by Nico César 8 months ago

#3 Updated by Nico César 8 months ago

  • Blocked by Feature #17349: [Keep API] Revisit "replicas_desired" and "storage_classes_desired". added

#4 Updated by Nico César 8 months ago

  • Description updated (diff)

#5 Updated by Tom Clegg 6 months ago

  • Target version deleted (To Be Groomed)
  • Status changed from New to Resolved

I think this is covered in #13431 -- see func (s *ServerRequiredSuite) TestStorageClassesHeader(c *C) in source:services/keepproxy/keepproxy_test.go

#6 Updated by Peter Amstutz 4 months ago

  • Target version set to 2021-06-23 sprint
  • Status changed from Resolved to Feedback
  • Subject changed from [keepproxy] Storage tiers to Storage classes support in keepproxy

#7 Updated by Peter Amstutz 4 months ago

  • Description updated (diff)

#8 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint

#9 Updated by Lucas Di Pentima 4 months ago

  • Assigned To set to Lucas Di Pentima
  • Status changed from Feedback to New

#10 Updated by Lucas Di Pentima 4 months ago

  • Status changed from New to In Progress

#11 Updated by Lucas Di Pentima 4 months ago

Updates at d02322793 - branch 17389-keepproxy-storage-classes-confirmed
Test run: https://ci.arvados.org/job/developer-run-tests/2533/

  • Returns the X-Keep-Storage-Classes-Confirmed header to the client on PUT success.
  • Adds test

The propagation of the X-Keep-Storage-Classes header from the client to the keepstores was already done in #13431

#12 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2021-07-07 sprint to 2021-06-23 sprint

#13 Updated by Lucas Di Pentima 4 months ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint

#14 Updated by Peter Amstutz 4 months ago

Lucas Di Pentima wrote:

Updates at d02322793 - branch 17389-keepproxy-storage-classes-confirmed
Test run: https://ci.arvados.org/job/developer-run-tests/2533/

  • Returns the X-Keep-Storage-Classes-Confirmed header to the client on PUT success.
  • Adds test

The propagation of the X-Keep-Storage-Classes header from the client to the keepstores was already done in #13431

One suggestion: add a comment explaining the logic (if the PUT succeeded, we are able to assume all the storage classes were fulfilled). Otherwise LGTM.

#15 Updated by Lucas Di Pentima 4 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF