Project

General

Profile

Actions
Copy link

Feature #17389

closed

Storage classes support in keepproxy

Added by Nico César over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
Keep
Target version:
2021-07-07 sprint
Story points:
-
Release:
Arvados 2.3.0
Release relationship:
Auto

Description

Support storage classes for PUT:

  • Propagate X-Keep-Storage-Classes headed received from clients, ensure that blocks are written to the correct storage classes
  • On success, return fulfilled X-Keep-Storage-Classes-Confirmed to client

Subtasks 1 (0 open — 1 closed)

Task #17819: Review 17389-keepproxy-storage-classes-confirmedResolvedPeter Amstutz06/18/2021Actions

Related issues

Related to Arvados Epics - Idea #16107: Storage classesResolved03/01/202109/30/2021Actions
Blocked by Arvados - Feature #17349: [Keep API] Revisit "replicas_desired" and "storage_classes_desired".RejectedActions
Actions
Copy link
 #1

Updated by Nico César over 3 years ago

  • Target version set to To Be Groomed
Actions
Copy link
 #2

Updated by Nico César over 3 years ago

Actions
Copy link
 #3

Updated by Nico César over 3 years ago

  • Blocked by Feature #17349: [Keep API] Revisit "replicas_desired" and "storage_classes_desired". added
Actions
Copy link
 #4

Updated by Nico César over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Tom Clegg over 3 years ago

  • Target version deleted (To Be Groomed)
  • Status changed from New to Resolved

I think this is covered in #13431 -- see func (s *ServerRequiredSuite) TestStorageClassesHeader(c *C) in source:services/keepproxy/keepproxy_test.go

Actions
Copy link
 #6

Updated by Peter Amstutz over 3 years ago

  • Target version set to 2021-06-23 sprint
  • Status changed from Resolved to Feedback
  • Subject changed from [keepproxy] Storage tiers to Storage classes support in keepproxy
Actions
Copy link
 #7

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #8

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint
Actions
Copy link
 #9

Updated by Lucas Di Pentima over 3 years ago

  • Assigned To set to Lucas Di Pentima
  • Status changed from Feedback to New
Actions
Copy link
 #10

Updated by Lucas Di Pentima over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #11

Updated by Lucas Di Pentima over 3 years ago

Updates at d02322793 - branch 17389-keepproxy-storage-classes-confirmed
Test run: developer-run-tests: #2533

  • Returns the X-Keep-Storage-Classes-Confirmed header to the client on PUT success.
  • Adds test

The propagation of the X-Keep-Storage-Classes header from the client to the keepstores was already done in #13431

Actions
Copy link
 #12

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2021-07-07 sprint to 2021-06-23 sprint
Actions
Copy link
 #13

Updated by Lucas Di Pentima over 3 years ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint
Actions
Copy link
 #14

Updated by Peter Amstutz over 3 years ago

Lucas Di Pentima wrote:

Updates at d02322793 - branch 17389-keepproxy-storage-classes-confirmed
Test run: developer-run-tests: #2533

  • Returns the X-Keep-Storage-Classes-Confirmed header to the client on PUT success.
  • Adds test

The propagation of the X-Keep-Storage-Classes header from the client to the keepstores was already done in #13431

One suggestion: add a comment explaining the logic (if the PUT succeeded, we are able to assume all the storage classes were fulfilled). Otherwise LGTM.

Actions
Copy link
 #15

Updated by Lucas Di Pentima over 3 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #16

Updated by Peter Amstutz almost 3 years ago

  • Release set to 42
Actions
Copy link

Also available in: Atom PDF