Bug #17436

Favorites in workflow picker dialog is different to favorite list

Added by Peter Amstutz 11 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
03/03/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

"I tested especially the favorites bug and for me it works in the copy dialog. However the same dialog used for the workflow input fields to select a project is still having the bug. I got a ticket again with this. Would that be an easy fix ?"


Subtasks

Task #17445: Review 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-listResolvedDaniel Kutyła


Related issues

Related to Arvados - Bug #17306: Favorites in copy dialog is different to favorite listResolved02/02/2021

Associated revisions

Revision e754a019
Added by Daniel Kutyła 10 months ago

Merge branch '17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-list'
closes #17436

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <>

Revision 274f2f94
Added by Daniel Kutyła 9 months ago

Merge branch '17436-Favorites-in-workflow-picker-dialog-is-different-to-favorites'
closes #17436

Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <>

History

#1 Updated by Peter Amstutz 11 months ago

  • Related to Bug #17306: Favorites in copy dialog is different to favorite list added

#2 Updated by Peter Amstutz 11 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 11 months ago

  • Assigned To set to Daniel Kutyła

#4 Updated by Peter Amstutz 11 months ago

  • Status changed from New to In Progress

#5 Updated by Daniel Kutyła 11 months ago

  • Assigned To deleted (Daniel Kutyła)

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/aef54eeec8f2e7255e2da119a19d14879dfb7b72
Test run: https://ci.arvados.org/job/developer-tests-workbench2/304/
Branch: 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-list

Added proper options to the tree picker, added tests

#6 Updated by Daniel Kutyła 11 months ago

  • Assigned To set to Daniel Kutyła

#7 Updated by Lucas Di Pentima 11 months ago

  • Can you explain to me what's the intention of the "checks that Public favorites does not appear under shared with me" test case? I know it's a test from other past branch, but it doesn't make sense to me the way it's written, following its name I think it should create a public favorite, and then click on the "shared with me" entry and confirm the just created favorite isn't there, but instead is just asserting that some string ("Public favorites") isn't there.
  • I think that re-using createSharedProjects() code isn't convenient, because it takes a lot of time to simulate a user sharing something many times, specially on a "Favorites" test suite. Could you instead create a similar function that's available to all the test suites (on cypress/support/commands.js) that uses API calls instead of interacting with the UI? I can help you with this if needed.
  • Also, the current createSharedProjects() code could be used on a new sharing.spec.js file to test just once the sharing dialog, what do you think?
  • There's one test case with the .only() call that avoids the rest to run.

#8 Updated by Daniel Kutyła 11 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/335fee64075faf3dac519fba45da5ecbe5008f33
Test run: https://ci.arvados.org/job/developer-tests-workbench2/305/
Branch: 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-list

Code cleanup

#9 Updated by Lucas Di Pentima 10 months ago

Some more testing related comments:

  • I think the Cypress command createSharedProjects() is too specific to be in the commands.js file. It even has side effects that make its use difficult to follow (setting predefined global variables that need to be accessed later). Do you think it would be better to just make a createSharedProject() (singular) command that takes an optional name and just returns the created+shared project, leaving all the small details of how many, and to which global var will be assigned, to its caller?
  • I think that testing the UI interaction for sharing is useful, but testing it many times doesn't have additional benefits and OTOH it adds test running time. The code that tested sharing interactions is now replaced with API calls completely, so now we aren't testing the sharing UI. I think it should be re-added to its own sharing.spec.js file or similar, do you agree?
  • The cy.loginAs() calls at file cypress/integration/favorites.spec.js lines 49, 102 and 140 are not needed and add testing time.

#10 Updated by Daniel Kutyła 10 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d2817690f88befb0c306e637d6e87367016c76e3
Test run: https://ci.arvados.org/job/developer-tests-workbench2/309/
Branch: 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorite-list

Added generic code for project creation within cypress tests

#11 Updated by Lucas Di Pentima 10 months ago

This LGTM, thanks!

#12 Updated by Daniel Kutyła 10 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

#13 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2021-03-17 sprint to 2021-04-14 sprint
  • Status changed from Resolved to Feedback

#14 Updated by Daniel Kutyła 9 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/a45b5f6f12e4e87c3ff0ce6f79a4999fef6e8bc5
Test run: https://ci.arvados.org/job/developer-tests-workbench2/3​68/
Branch: 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorites

Added additional test for directory picker

#15 Updated by Daniel Kutyła 9 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/2b3fa73903f8f485df9783f16f00ad05098f9270
Test run: https://ci.arvados.org/job/developer-tests-workbench2/3​69/
Branch: 17436-Favorites-in-workflow-picker-dialog-is-different-to-favorites

Removed 'only' from test suite

#16 Updated by Daniel Kutyła 9 months ago

  • Status changed from Feedback to Resolved

#17 Updated by Peter Amstutz 8 months ago

  • Release set to 38

Also available in: Atom PDF