Arvados

I've been looking for methods to reduce test flakyness. I think that one of the causes is the fact that we use cy.visit() to go to specific URLs. This makes the browser go to the url and reloading the entire app in the process... which introduces delays because on app boostrap, there're lots of things going on in the background.

One idea would be to stop using cy.visit() and somehow access the app's router from Cypress, so we can push new URLs to the browser's history and let the app react to it, this I think will improve response times a lot. I've found a couple of hints on how to do this:

https://github.com/cypress-io/cypress/issues/128#issuecomment-406155816

and more react specific:

https://github.com/cypress-io/cypress/issues/3120#issuecomment-453254393

Updates at arvados-workbench2|e76af0d - branch 17500-cypress-flakyness-fixes

• developer-tests-workbench2: #385
• developer-tests-workbench2: #386
• developer-tests-workbench2: #387
• developer-tests-workbench2: #388
• developer-tests-workbench2: #389

• Avoids using multi-slash URLs on Cypress requests.
• Fixes issue that made the 'page not found' message to not be displayed on unknown routes.
• Adds app router navigation capabilities to Cypress tests, to improve reliability and speed.
• Adds object cleanup before every test to avoid potential issues and test slowness.
• Fixes cy.loginAs() command to avoid leaking session data if used more than once on a single test.
• Fixes favorites suite test that relied on the above bug to sometimes pass.

Lucas Di Pentima wrote:

Updates at arvados-workbench2|e76af0d - branch 17500-cypress-flakyness-fixes

Test runs:

• developer-tests-workbench2: #385
• developer-tests-workbench2: #386
• developer-tests-workbench2: #387
• developer-tests-workbench2: #388
• developer-tests-workbench2: #389

Fixes:

• Avoids using multi-slash URLs on Cypress requests.
• Fixes issue that made the 'page not found' message to not be displayed on unknown routes.
• Adds app router navigation capabilities to Cypress tests, to improve reliability and speed.
• Adds object cleanup before every test to avoid potential issues and test slowness.
• Fixes cy.loginAs() command to avoid leaking session data if used more than once on a single test.
• Fixes favorites suite test that relied on the above bug to sometimes pass.

This LGTM