https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-03-31T14:19:40ZArvadosArvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=915252021-03-31T14:19:40ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-03-31 sprint</i> to <i>2021-04-14 sprint</i></li></ul> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=915912021-03-31T18:27:24ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=915972021-03-31T22:10:09ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Fix at <a class="changeset" title="17508: Fixes arv-keepdocker bug. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-penti..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/3b011a2c617b35412a7e403b5db38a708a2f220c">3b011a2</a> - branch <code>17508-arvkeepdocker-fix</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2395/"<a href="https://ci.arvados.org/job/developer-run-tests/2395/">developer-run-tests: #2395 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2395" alt="" /></a></a></p>
<ul>
<li>Makes <code>arv-keepdocker</code> request the newly created collection before updating it with a new property, just in case it already has other properties.</li>
<li>Adds unit test.</li>
</ul> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=916002021-04-01T13:33:10ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Merged master with an unrelated fix at <a class="changeset" title="Merge branch 'master' into 17508-arvkeepdocker-fix Arvados-DCO-1.1-Signed-off-by: Lucas Di Penti..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/341a593189ffe0ceb158b634de987c1758fabfd5">341a593</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2395/"<a href="https://ci.arvados.org/job/developer-run-tests/2395/">developer-run-tests: #2395 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2395" alt="" /></a></a></p> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=916012021-04-01T13:42:23ZTom Cleggtom@curii.com
<ul></ul><p>Just one nit: I think it would be a bit safer to do this</p>
<pre><code class="diff syntaxhl"><span class="gd">- api().collections().get().execute.return_value = mocked_collection
</span><span class="gi">+ api().collections().get().execute.return_value = copy.deepcopy(mocked_collection)
</span></code></pre>
<p>to ensure the comparison with mocked_collection['properties'] still does what it looks like it does, even though the tested code modifies the values of the dict returned by execute().</p>
<p>Besides that, LGTM, thanks.</p> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=916032021-04-01T13:54:34ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Applied suggested changes at <a class="changeset" title="17508: Fixes unit test. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas@di-pentima.com.ar>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/fdfa3253c0da07a80a21c84c58a18c3a49a9220a">fdfa325</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2398/"<a href="https://ci.arvados.org/job/developer-run-tests/2398/">developer-run-tests: #2398 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2398" alt="" /></a></a></p> Arvados - Bug #17508: Arv-keepdocker implicitly tries to delete a collection protected propertyhttps://dev.arvados.org/issues/17508?journal_id=916062021-04-01T15:05:39ZAnonymous
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '17508-arvkeepdocker-fix' Closes #17508 Arvados-DCO-1.1-Signed-off-by: Lucas Di Pen..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c937aa7011849b84cf5a0bb01c18e262a94f95ad">arvados|c937aa7011849b84cf5a0bb01c18e262a94f95ad</a>.</p>