Bug #17526

[workbench2] UX improvements for collections 3rd party access information

Added by Ward Vandewege 5 months ago. Updated 23 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
07/28/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This came up while writing up instructions for novice users on how to download data from a collection.

Here are a few suggestions about the "Open as Network Folder or S3 Bucket" popup.

1) Can we rename it to "Access with 3rd party client" or something like that?

2) the "Cyberduck/Mountain Duck or Gnome Files" tab could be renamed "WebDAV"? And Cyberduck/Mountain Duck could be mentioned as WebDAV clients on that tab.

3) the "wget" command line is provided on the keep-web page linked from the top of the "Windows or MacOS" tab. Can we add a new tab (called "wget/curl"? with the wget command copyable, right there? Would have to look at the keep-web logic that generates the command. Would also need to list the username/password.

4) the instructions for "Windows or MacOS" may be better with one more step that says to use the "internet address" and credentials listed above. Something like:

Windows:
4. Use the "internet address" and credentials listed under Settings, above.

and

MacOS:
3. Use the "internet address" and credentials listed under Settings, above.

I also wonder what the best "default" first tab is.


Subtasks

Task #17541: Review 17526-3rd-party-access-uiResolvedLucas Di Pentima

Associated revisions

Revision 02370859
Added by Stephen Smith about 2 months ago

Merge branch '17526-3rd-party-access-ui' into main. Closes #17526

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <>

History

#1 Updated by Ward Vandewege 5 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 5 months ago

  • Assigned To set to Lucas Di Pentima

#3 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-04-28 bughunt sprint to 2021-05-12 sprint

#4 Updated by Lucas Di Pentima 4 months ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint

#5 Updated by Lucas Di Pentima 4 months ago

  • Target version changed from 2021-05-26 sprint to 2021-06-09 sprint

#6 Updated by Peter Amstutz 3 months ago

  • Target version changed from 2021-06-09 sprint to 2021-06-23 sprint

#7 Updated by Lucas Di Pentima 3 months ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint

#8 Updated by Peter Amstutz 3 months ago

  • Target version changed from 2021-07-07 sprint to 2021-07-21 sprint

#9 Updated by Peter Amstutz 2 months ago

  • Target version changed from 2021-07-21 sprint to 2021-08-04 sprint

#10 Updated by Peter Amstutz about 2 months ago

  • Assigned To deleted (Lucas Di Pentima)

#11 Updated by Stephen Smith about 2 months ago

  • Assigned To set to Stephen Smith

#12 Updated by Stephen Smith about 2 months ago

Updates at 9df0dc3888f9d63ae0844e7425cd02b21af9da68 - branch 17526-3rd-party-access-ui
Tests: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/450/

  • Rename webdav dialong to Access with 3rd party client
  • Rename cyberduck tab to webdav, mention credentials in mac/win tab
  • Add wget/curl tab to webdav dialog

#13 Updated by Lucas Di Pentima about 2 months ago

Some comments:

  • As the context menu items are ordered by label, I think it would be better to name it "Open with 3rd party client" to keep it on the same place and avoid user confusion.
  • The "wget / curl" tab:
    • The supportsWebdav boolean I guess it should be renamed to something like isCollection because that's what the 4zz18 prefix means (https://doc.arvados.org/v2.2/api/methods/collections.html)
    • It already provides the username/password on the wget command (good idea!), so I think it isn't necessary to specify them separately.
    • The "Copy to clipboard" button just copies the collection's URL, I think it would be better to copy the entire command so that the user can easily paste it on the shell.
    • How about adding a curl command too for completeness' sake?
    • Also, I think it would be nice to format those commands using monospaced fonts as we do on the "Get API Token" user menu dialog, wdyt?

#14 Updated by Stephen Smith about 2 months ago

All good suggestions - a note about curl since it seems it doesn't support parsing the html and downloading the whole folder, I added a <FILENAME> at the end of the curl url. Do you think that's ok and/or should I add a note? I don't see this dialog option on files so I think the url should be a folder in every case unless I'm missing a path to make the dialog come up for a specific file.

Updates at 41a579060898b29e6d50000e6f95c93d97a7a433
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/451/

  • Change webdav dialog title to "Open" to preserve ordering
  • Rename supportsWebdav to isCollection
  • Fix webdav dialog > wget tab command copy button only copying url
  • Use codesnippet component on webdav dialog wget command for monospace
  • Remove redundant user/pass from webdav wget tab and add curl command

#15 Updated by Stephen Smith about 2 months ago

  • Status changed from New to In Progress

#16 Updated by Lucas Di Pentima about 2 months ago

Some small comments:

  • You're right, I forgot that curl doesn't do mirroring, I think it would be nice to have a brief note by the "Curl command" label to clarify that's meant for downloading individual files, because the <FILENAME> tag isn't visible at first unless the user scrolls to all the way to the right.
  • One additional nit: In the WEBDAV tab, I think it's more correct to mention GNOME (all caps) instead of Gnome. GNOME is an acronym IIRC.

The rest looks good to merge, thanks!

#17 Updated by Stephen Smith about 2 months ago

  • Status changed from In Progress to Resolved

Merged in 02370859e71ada20e2247df02958a9c532fe614b

#18 Updated by Peter Amstutz 23 days ago

  • Release set to 41

Also available in: Atom PDF