Feature #17532

Collection version history panel adds column for modified_by_user_uuid (by user name) for each past version.

Added by Peter Amstutz 5 months ago. Updated 23 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
08/10/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #17543: Review 17532-collection-version-history-usernameResolvedLucas Di Pentima

Associated revisions

Revision 2e83c4e7
Added by Stephen Smith about 1 month ago

Merge branch '17532-collection-version-history-username' into main. Closes #17532

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <>

History

#1 Updated by Peter Amstutz 5 months ago

  • Assigned To set to Daniel Kutyła

#2 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-04-28 bughunt sprint to 2021-05-12 sprint

#3 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint

#4 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2021-05-26 sprint to 2021-06-09 sprint

#5 Updated by Peter Amstutz 3 months ago

  • Target version changed from 2021-06-09 sprint to 2021-07-07 sprint

#6 Updated by Peter Amstutz 3 months ago

  • Target version changed from 2021-07-07 sprint to 2021-07-21 sprint

#7 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-07-21 sprint to 2021-08-18 sprint

#8 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-08-18 sprint to 2021-09-01 sprint

#9 Updated by Peter Amstutz about 2 months ago

  • Assigned To deleted (Daniel Kutyła)

#10 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-09-01 sprint to 2021-08-18 sprint

#11 Updated by Peter Amstutz about 1 month ago

  • Assigned To set to Stephen Smith

#12 Updated by Stephen Smith about 1 month ago

  • Status changed from New to In Progress

#13 Updated by Stephen Smith about 1 month ago

Changes at arvados-workbench2|81e046c27b73760acc5bffd51019516a2bbad94c
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/461/

I created a new renderer function to provide username from UUID and a helper function to reduce code duplication. I had to squeeze some of the other columns to make space.

#14 Updated by Lucas Di Pentima about 1 month ago

Some comments:

  • I think the new column is too narrow, possible solutions would be:
    • Make the right-hand side panel width-adjustable like the left-hand side panel
    • Add the user's name/uuid data as a second row spanning all columns of the same version's row
  • The font used for the name/uuid is a little bigger than the font of the rest of the version browser (14 vs 12 px)
  • I think the new column's name should say something like "Modified by" instead of just "User", so it's not confused with its owner (please check with Peter just in case)
  • Could you update the cypress test to check for the new data being displayed on the collection browser? Bonus points if the test confirms that a version created by a user other than the owner is correctly shown on the UI. (for example, making some change with the admin user on a regular user owned collection)

#15 Updated by Stephen Smith about 1 month ago

Updated 6d6ea46757e93939c12d026faf9fd3c4d7b83122
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/464/

I addressed all the points you raised - there's one potential problem that the "Admin User" shows up as a UUID, I'm not sure if this is because of how the permissions between the adminUser and activeUser in cypress that prevents the code in renderers from getting the user details or whether there is some omission in fetching user details that needs to be fixed. In theory I think renderers.tsx:L432 should be fetching user details when available.

#16 Updated by Lucas Di Pentima about 1 month ago

Stephen Smith wrote:

I addressed all the points you raised - there's one potential problem that the "Admin User" shows up as a UUID, I'm not sure if this is because of how the permissions between the adminUser and activeUser in cypress that prevents the code in renderers from getting the user details or whether there is some omission in fetching user details that needs to be fixed. In theory I think renderers.tsx:L432 should be fetching user details when available.

I think this works great, the issue with the admin user's full name I believe is what you described: the normal user doesn't have read access to it. Looks good to merge, thanks!

#17 Updated by Stephen Smith about 1 month ago

  • Status changed from In Progress to Resolved

#18 Updated by Peter Amstutz 23 days ago

  • Release set to 41

Also available in: Atom PDF