Bug #17603

[deployment][provision] webshell nginx pillar is being deployed but not applied

Added by Javier Bértoli 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Start date:
05/28/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

The webshell's pillar is being deployed in the shell role, but no nginx is deployed there so the webshell service is not working.

The provision script should:

#. Deploy the nginx's webshell vhost in a public facing node (workbench?)
#. Make sure the webshell's configuration points to the shell node and shellinabox port

(Checking in the clusters I have access to, webshell FQDN is never exposed to the user, being proxy-passed by nginx. Therefore, does webshell's FQDN be an internet FQDN/IP? Or is it enough to make it a private resource, for security sake?)


Subtasks

Task #17644: Review #17603 nginx-webshell-vhost-fixResolvedJavier Bértoli


Related issues

Blocks Arvados - Story #17512: Release Arvados 2.2Resolved05/03/2021

Associated revisions

Revision 35bf3afb (diff)
Added by Javier Bértoli 5 months ago

17603: Enable webshell role pillars in provision script

refs #17603
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <>

Revision ed4d8462
Added by Javier Bértoli 5 months ago

Merge branch '17603-nginx-webshell-vhost-fix'

closes #17603
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <>

History

#1 Updated by Peter Amstutz 6 months ago

#2 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint

#3 Updated by Peter Amstutz 5 months ago

  • Release set to 38

#4 Updated by Javier Bértoli 5 months ago

  • Status changed from New to In Progress

#5 Updated by Javier Bértoli 5 months ago

  • Release deleted (38)

Should be fixed in commit c066b22b6@arvados, branch 17603-nginx-webshell-vhost-fix

#6 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-05-26 sprint to 2021-06-09 sprint

#7 Updated by Javier Bértoli 5 months ago

  • Status changed from In Progress to Feedback

Added some more changes and tested. 0532a70b5 branch 17603-nginx-webshell-vhost-fix

#8 Updated by Lucas Di Pentima 5 months ago

This LGTM, thanks!

#9 Updated by Javier Bértoli 5 months ago

  • Status changed from Feedback to Resolved

Merged

Also available in: Atom PDF