Project

General

Profile

Actions
Copy link

Bug #17605

closed

[deployment][provision] letsencrypt credentials when using route53

Added by Javier Bértoli almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Javier Bértoli
Category:
Deployment
Target version:
2021-06-09 sprint
Story points:
-
Release:
Arvados 2.2.0
Release relationship:
Auto

Description

When the provision script deploys in AWS using route53 for Letsencrypt validation, the credentials need to be stored in a ~/.aws/config file.

We should add an extra state to create the file if it's not there.

Subtasks 1 (0 open — 1 closed)

Task #17642: Review #17605 letsencrypt-credentials-for-route53ResolvedJavier Bértoli05/28/2021Actions

Related issues

Blocks Arvados - Idea #17512: Release Arvados 2.2ResolvedPeter Amstutz05/03/2021Actions
Blocks Arvados - Bug #17604: [deployment][provision][arvados-formula] remove @*--collections@ and use @*.collections@ ResolvedJavier Bértoli05/18/2021Actions
Actions
Copy link
 #1

Updated by Peter Amstutz almost 3 years ago

Actions
Copy link
 #2

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint
Actions
Copy link
 #3

Updated by Peter Amstutz almost 3 years ago

  • Assigned To changed from Javier Bértoli to Nico César
Actions
Copy link
 #4

Updated by Peter Amstutz almost 3 years ago

  • Release set to 38
Actions
Copy link
 #5

Updated by Javier Bértoli almost 3 years ago

  • Blocks Bug #17604: [deployment][provision][arvados-formula] remove @*--collections@ and use @*.collections@ added
Actions
Copy link
 #6

Updated by Javier Bértoli almost 3 years ago

  • Assigned To changed from Nico César to Javier Bértoli
  • Status changed from New to In Progress
Actions
Copy link
 #7

Updated by Javier Bértoli almost 3 years ago

Pushed c3a5a3a4, branch 17605-letsencrypt-credentials-for-route53. Need to test it

Actions
Copy link
 #8

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2021-05-26 sprint to 2021-06-09 sprint
Actions
Copy link
 #9

Updated by Javier Bértoli almost 3 years ago

  • Status changed from In Progress to Feedback

Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.

Actions
Copy link
 #10

Updated by Ward Vandewege almost 3 years ago

Javier Bértoli wrote:

Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.

Just one comment - you use comparisons like this:

if [ "x${USE_LETSENCRYPT_IAM_USER}" = "xyes" ]; then

There is no need to have 'x' in those comparisons. Bash does not need that.

LGTM otherwise.

Actions
Copy link
 #11

Updated by Javier Bértoli almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF