Bug #17605

[deployment][provision] letsencrypt credentials when using route53

Added by Javier Bértoli 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Start date:
05/28/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When the provision script deploys in AWS using route53 for Letsencrypt validation, the credentials need to be stored in a ~/.aws/config file.

We should add an extra state to create the file if it's not there.


Subtasks

Task #17642: Review #17605 letsencrypt-credentials-for-route53ResolvedJavier Bértoli


Related issues

Blocks Arvados - Story #17512: Release Arvados 2.2Resolved05/03/2021

Blocks Arvados - Bug #17604: [deployment][provision][arvados-formula] remove @*--collections@ and use @*.collections@ Resolved05/18/2021

Associated revisions

Revision c3a5a3a4 (diff)
Added by Javier Bértoli 5 months ago

feat(provision): add AWS credentials for letsencrypt

Wildcard certiticates need to be obtained through a DNS-01 challenge

refs #17605
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <>

Revision be93d1d2
Added by Javier Bértoli 5 months ago

Merge branch '17605-letsencrypt-credentials-for-route53'

closes #17605
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <>

History

#1 Updated by Peter Amstutz 6 months ago

#2 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint

#3 Updated by Peter Amstutz 5 months ago

  • Assigned To changed from Javier Bértoli to Nico César

#4 Updated by Peter Amstutz 5 months ago

  • Release set to 38

#5 Updated by Javier Bértoli 5 months ago

  • Blocks Bug #17604: [deployment][provision][arvados-formula] remove @*--collections@ and use @*.collections@ added

#6 Updated by Javier Bértoli 5 months ago

  • Assigned To changed from Nico César to Javier Bértoli
  • Status changed from New to In Progress

#7 Updated by Javier Bértoli 5 months ago

Pushed c3a5a3a4, branch 17605-letsencrypt-credentials-for-route53. Need to test it

#8 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2021-05-26 sprint to 2021-06-09 sprint

#9 Updated by Javier Bértoli 5 months ago

  • Status changed from In Progress to Feedback

Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.

#10 Updated by Ward Vandewege 5 months ago

Javier Bértoli wrote:

Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.

Just one comment - you use comparisons like this:

if [ "x${USE_LETSENCRYPT_IAM_USER}" = "xyes" ]; then

There is no need to have 'x' in those comparisons. Bash does not need that.

LGTM otherwise.

#11 Updated by Javier Bértoli 5 months ago

  • % Done changed from 0 to 100
  • Status changed from Feedback to Resolved

Also available in: Atom PDF