Bug #17605
closed
[deployment][provision] letsencrypt credentials when using route53
Added by Javier Bértoli over 3 years ago.
Updated over 3 years ago.
Assigned To:
Javier Bértoli
Release relationship:
Auto
Description
When the provision script deploys in AWS using route53 for Letsencrypt validation, the credentials need to be stored in a ~/.aws/config
file.
We should add an extra state to create the file if it's not there.
- Target version changed from 2021-05-12 sprint to 2021-05-26 sprint
- Assigned To changed from Javier Bértoli to Nico César
- Blocks Bug #17604: [deployment][provision][arvados-formula] remove @*--collections@ and use @*.collections@ added
- Assigned To changed from Nico César to Javier Bértoli
- Status changed from New to In Progress
Pushed c3a5a3a4, branch 17605-letsencrypt-credentials-for-route53. Need to test it
- Target version changed from 2021-05-26 sprint to 2021-06-09 sprint
- Status changed from In Progress to Feedback
Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.
Javier Bértoli wrote:
Added a few more fixes in 25c42aa40, branch 17605-letsencrypt-credentials-for-route53
Should be OK now.
Just one comment - you use comparisons like this:
if [ "x${USE_LETSENCRYPT_IAM_USER}" = "xyes" ]; then
There is no need to have 'x' in those comparisons. Bash does not need that.
LGTM otherwise.
- % Done changed from 0 to 100
- Status changed from Feedback to Resolved
Also available in: Atom
PDF