Project

General

Profile

Actions

Bug #17606

closed

[deployment][provision] extra dirs and files are poorly managed

Added by Javier Bértoli over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Start date:
05/18/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When the script finds no extra dir/files, a wildcard file is created (extras/\*) as a result.

This makes salt fail.

The loops replacing variables seem to be responsible for this.


Subtasks 1 (0 open1 closed)

Task #17641: Review #17606 provision script file-globbing-issuesResolvedLucas Di Pentima05/18/2021

Actions

Related issues

Blocks Arvados - Story #17512: Release Arvados 2.2ResolvedPeter Amstutz05/03/2021

Actions
Actions #1

Updated by Peter Amstutz over 1 year ago

Actions #2

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2021-05-12 sprint to 2021-05-26 sprint
Actions #3

Updated by Peter Amstutz over 1 year ago

  • Assigned To changed from Javier Bértoli to Nico César
Actions #4

Updated by Peter Amstutz over 1 year ago

  • Release set to 38
Actions #5

Updated by Javier Bértoli over 1 year ago

  • Assigned To changed from Nico César to Javier Bértoli
  • Status changed from New to In Progress
Actions #6

Updated by Javier Bértoli over 1 year ago

  • Status changed from In Progress to Feedback

The issue is a bash globbing issue, so instead of using nullglob, I used a subshell to list files where required.

Tested: removed the files from config_examples/single_host/multiple_hostnames/states/, run it before and after the change and works as expected.

Fixed commit 941b5806c@arvados, branch 17606-file-globbing-issues

Actions #7

Updated by Lucas Di Pentima over 1 year ago

This LGTM, thanks!

Actions #8

Updated by Javier Bértoli over 1 year ago

  • Status changed from Feedback to Resolved

Merged

Actions

Also available in: Atom PDF