https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-04-29T22:26:42ZArvadosArvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=923132021-04-29T22:26:42ZJavier Bértolijbertoli@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=923142021-04-29T22:32:11ZJavier Bértolijbertoli@curii.com
<ul></ul><p>We're already running a pre-deploy check of the configuration (commit 4bf9501a@arvados-formula).</p> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=923622021-05-04T19:23:42ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-6 status-3 priority-4 priority-default closed parent" href="/issues/17512">Idea #17512</a>: Release Arvados 2.2</i> added</li></ul> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=923992021-05-05T15:14:37ZJavier Bértolijbertoli@curii.com
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Changed from</p>
<p><code>/usr/bin/arvados-server config-dump -config</code></p>
<p>to</p>
<p><code>check_command: /usr/bin/arvados-server config-check -config</code></p>
<p>configurable through pillars (commit ee82273@arvados-formula)</p>
<p>Now, check is strict, so we make sure that configuration is arvados-compatible.</p>
<p><a href="https://ci.arvados.org/job/test-saltstack-arvados-formula/label=tests-2.1/15" class="external">Test pass</a></p> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=924272021-05-05T19:44:16ZJavier Bértolijbertoli@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=924422021-05-06T22:53:08ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>I've been reading the basics on SaltStack, so please if you detect some conceptual flaws on my questions, feel free to correct me :)</p>
<p>- General Q: The "<code>Get the `tplroot` from `tpldir`</code>" code block seem to be duped in every sls file. Could that be moved to the root <code>init.sls</code> file or some other shared place so it's declared once?<br />- General Q II: I had to clone the <code>arvados-formula</code> repo from github. Is it hosted also on our own repo? If not, should it be hosted there and mirrored to github?<br />- Typo in <code>pillar.example</code> comment: s/intalling/installing <br />- At <code>pillar.example</code>: shouldn't the <code>config.check_command</code> key have some default value? I ask because there're other keys with uncommented values, so someone using the example would need to set something on <code>check_command</code> for the lookup to work, right? AFAICT the <code>arvados/config/file.sls</code> formula doesn't have a fallback value for <code>check_cmd</code> if the pillar value isn't set, or would that produce a null value that will make the <code>check_cmd</code> primitive be disabled? If that's the case, should we try to avoid not checking the config? We even recommend checking the config in the pillar example, so maybe it's a good idea to make it a default?</p> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=924492021-05-07T14:01:11ZJavier Bértolijbertoli@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>- General Q: The "<code>get the `tplroot` from `tpldir`</code>" code block seem to be duped in every sls file. Could that be moved to the root <code>init.sls</code> file or some other shared place so it's declared once?</p>
</blockquote>
<blockquote>
<p>- General Q II: I had to clone the <code>arvados-formula</code> repo from github. Is it hosted also on our own repo? If not, should it be hosted there and mirrored to github?</p>
</blockquote>
<p>Yes, we have 3 places atm:</p>
<ul>
<li>our own repo,</li>
<li>the github one and</li>
<li>the <code>saltstack-formulas</code> one. But this last one, as it tries to follow a set of different rules that we follow regarding versioning and such, I'm managing it through PRs to keep it updated. And currently, is outdated, waiting for this set of fixes to be updated.</li>
</ul>
<p>We refer everyone to <code>github/arvados-formula</code> in our docs. Mirroring it from our own would be a great improvement.</p>
<blockquote>
<p>- Typo in <code>pillar.example</code> comment: s/intalling/installing</p>
</blockquote>
<p>Thanks, fixed in another branch.</p>
<blockquote>
<p>- At <code>pillar.example</code>: shouldn't the <code>config.check_command</code> key have some default value? I ask because there're other keys with uncommented values, so someone using the example would need to set something on <code>check_command</code> for the lookup to work, right? AFAICT the <code>arvados/config/file.sls</code> formula doesn't have a fallback value for <code>check_cmd</code> if the pillar value isn't set, or would that produce a null value that will make the <code>check_cmd</code> primitive be disabled? If that's the case, should we try to avoid not checking the config? We even recommend checking the config in the pillar example, so maybe it's a good idea to make it a default?</p>
</blockquote>
<p>Defaults in saltstack formulas are set in <code><formula>/*yaml</code> files, which are merged (through <code>map.jinja</code>) in certain order and finally with the pillar data, to get the configuration that will be applied to the minion.</p>
<p>In this case, the <code>check_command: /usr/bin/arvados-server config-check -config</code> set in <code>arvados/defaults.yaml</code> will be used if no value is set by the user.</p> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=925672021-05-12T15:51:24ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-05-12 sprint</i> to <i>2021-05-26 sprint</i></li></ul> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=926032021-05-12T19:21:18ZJavier Bértolijbertoli@curii.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul> Arvados - Feature #17608: [deployment][arvados-formula] run @arvados-server --config-check@ on all the roles but shellhttps://dev.arvados.org/issues/17608?journal_id=926942021-05-13T15:29:18ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>38</i></li></ul>