Bug #17637

"Not found" error when trashing project

Added by Peter Amstutz 9 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
05/13/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

It displays a spurious "not found" error when trashing a project. It appears to happen because the project is still considered selected after it has been trashed.

Steps to reproduce:

  1. Create a subproject
  2. Click on the subproject so it is displayed in the main panel
  3. Right-click on the subproject on the left tree view and select "move to trash"
  4. The project will be correctly trashed, but it will pop up a confusing dialog saying the project is not found

Subtasks

Task #17670: Review 17637-not-found-after-trashResolvedPeter Amstutz


Related issues

Blocks Arvados - Story #17512: Release Arvados 2.2Resolved05/03/2021

Associated revisions

Revision 976f4f27
Added by Lucas Di Pentima 8 months ago

Merge branch '17637-not-found-after-trash'
Closes #17637

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 9 months ago

#3 Updated by Peter Amstutz 8 months ago

  • Assigned To set to Lucas Di Pentima

#4 Updated by Lucas Di Pentima 8 months ago

  • Status changed from New to In Progress

#5 Updated by Lucas Di Pentima 8 months ago

Updates at arvados-workbench2|55b961b - branch 17637-not-found-after-trash
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/415/

  • Fixes "not found" error message/dialog after trashing a project.
  • Removes superfluous snackbar "About to do X..." messages when trashing groups and collections.
  • Fixes error messages when untrashing collections and projects.
  • Navigates to the recently untrashed project.
  • Updates the projects tree on the left side panel after trashing a project.
  • Adds cypress test.

#6 Updated by Peter Amstutz 8 months ago

  • Release set to 38

#7 Updated by Peter Amstutz 8 months ago

Lucas Di Pentima wrote:

Updates at arvados-workbench2|55b961b - branch 17637-not-found-after-trash
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/415/

  • Fixes "not found" error message/dialog after trashing a project.

I found an edge case:

  1. Create a project
  2. Create a subproject
  3. Select the subproject
  4. Right click on the parent project and trash it
  5. You still get the "not found" error and the project tree gets confused
  • Removes superfluous snackbar "About to do X..." messages when trashing groups and collections.
  • Fixes error messages when untrashing collections and projects.
  • Navigates to the recently untrashed project.
  • Updates the projects tree on the left side panel after trashing a project.
  • Adds cypress test.

#8 Updated by Lucas Di Pentima 8 months ago

Peter Amstutz wrote:

I found an edge case:

Good catch! I've simplified and fixed the issue, and in the process fixed another one that slipped through: the side panel tree wasn't being updated on some occasions.

Updates at arvados-workbench2|f6d52fc8
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/416/

#9 Updated by Peter Amstutz 8 months ago

Lucas Di Pentima wrote:

Peter Amstutz wrote:

I found an edge case:

Good catch! I've simplified and fixed the issue, and in the process fixed another one that slipped through: the side panel tree wasn't being updated on some occasions.

Updates at arvados-workbench2|f6d52fc8
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/416/

This LGTM, thanks!

#10 Updated by Lucas Di Pentima 8 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF