Bug #17682

[arvados-client] shell stutter

Added by Ward Vandewege 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
05/26/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

When connecting via a container request UUID, the "connecting to container ..." line is printed twice:

$ ./arvados-client shell ce8i5-xvhdp-e6wnujfslyyqn4b 
connecting to container ce8i5-dz642-h1cl0sa62d4i430
connecting to container ce8i5-dz642-h1cl0sa62d4i430
root@0f13dcd755fa:~# 

When using the container request, nothing like that is printed:

$ ./arvados-client shell ce8i5-dz642-h1cl0sa62d4i430
root@0f13dcd755fa:~# 

Subtasks

Task #17730: Review 17682-fix-stutterResolvedTom Clegg


Related issues

Related to Arvados Epics - Story #17207: External access to web services running in containersNew03/01/202206/30/2022

Associated revisions

Revision ba56503f
Added by Tom Clegg 5 months ago

Merge branch '17682-fix-stutter'

fixes #17682

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Ward Vandewege 5 months ago

  • Related to Story #17207: External access to web services running in containers added

#2 Updated by Ward Vandewege 5 months ago

  • Description updated (diff)

#3 Updated by Ward Vandewege 5 months ago

  • Description updated (diff)

#4 Updated by Ward Vandewege 5 months ago

  • Description updated (diff)

#5 Updated by Tom Clegg 5 months ago

As a side effect, this fix also avoids an extra API call and avoids the possibility, when a container request UUID is supplied, of setting up a "probe" tunnel to container A and then (due to cancel/retry) setting up the real tunnel to a different container B. (This seems pretty harmless but could produce mildly confusing results.)

17682-fix-stutter @ e9ab3d864a8deb2810d7a49b0529a2aef0c0b41c -- https://ci.arvados.org/view/Developer/job/developer-run-tests/2480/

#6 Updated by Tom Clegg 5 months ago

  • Assigned To set to Tom Clegg
  • Status changed from New to In Progress

#7 Updated by Ward Vandewege 5 months ago

Tom Clegg wrote:

As a side effect, this fix also avoids an extra API call and avoids the possibility, when a container request UUID is supplied, of setting up a "probe" tunnel to container A and then (due to cancel/retry) setting up the real tunnel to a different container B. (This seems pretty harmless but could produce mildly confusing results.)

17682-fix-stutter @ e9ab3d864a8deb2810d7a49b0529a2aef0c0b41c -- https://ci.arvados.org/view/Developer/job/developer-run-tests/2480/

LGTM, thanks!

#8 Updated by Tom Clegg 5 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF