Bug #17690

[Workbench2] as an admin user, the /ssh-keys-user url (*user* ssh keys menu) shows everyone's keys

Added by Ward Vandewege 4 months ago. Updated 27 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
08/04/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

As an admin user, when selecting the "Ssh Keys" menu in the user menu (at /ssh-keys-user), I get a page that shows everyone's keys, instead of just mine.

This is the same content as the "Ssh Keys" page from the admin menu (which is at /ssh-keys-admin).

The page at /ssh-keys-user should only ever show the user's own keys, even when that user is an admin user. The page at /ssh-keys-admin is behaving properly and should not change.


Subtasks

Task #17963: Review 17690-user-ssh-key-pageResolvedStephen Smith

Associated revisions

Revision ce576a60
Added by Stephen Smith about 2 months ago

Merge branch '17690-user-ssh-key-page' into main. Closes #17690

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <>

History

#1 Updated by Ward Vandewege 4 months ago

  • Description updated (diff)

#2 Updated by Stephen Smith about 2 months ago

  • Assigned To set to Stephen Smith
  • Status changed from New to In Progress

#3 Updated by Stephen Smith about 2 months ago

  • Target version set to 2021-08-04 sprint

#4 Updated by Stephen Smith about 2 months ago

I found that both user ssh keys and admin ssh keys routes both used the same component stack, so I duplicated ssh-key-panel to ssh-key-admin-panel and added filtering to ssh-key-panel.

Changes at 7bdf07a2661affc4f1496d73e27d16f6470e4e4a branch 17690-user-ssh-key-page
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/455/

#5 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-08-04 sprint to 2021-08-18 sprint

#6 Updated by Ward Vandewege about 2 months ago

Stephen Smith wrote:

I found that both user ssh keys and admin ssh keys routes both used the same component stack, so I duplicated ssh-key-panel to ssh-key-admin-panel and added filtering to ssh-key-panel.

Changes at 7bdf07a2661affc4f1496d73e27d16f6470e4e4a branch 17690-user-ssh-key-page
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/455/

Thanks, LGTM!

#7 Updated by Stephen Smith about 2 months ago

  • Status changed from In Progress to Resolved

#8 Updated by Peter Amstutz 27 days ago

  • Release changed from 31 to 41

Also available in: Atom PDF