https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-05-18T18:12:30ZArvadosArvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=928092021-05-18T18:12:30ZWard Vandewegeward@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/92809/diff?detail_id=89474">diff</a>)</li></ul> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=956702021-07-30T15:41:06ZWard Vandewegeward@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/95670/diff?detail_id=92340">diff</a>)</li></ul> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=956712021-07-30T15:43:12ZWard Vandewegeward@curii.com
<ul><li><strong>Release</strong> deleted (<del><i>31</i></del>)</li><li><strong>Target version</strong> set to <i>2021-08-04 sprint</i></li><li><strong>Assigned To</strong> set to <i>Stephen Smith</i></li></ul> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=956842021-08-02T13:55:23ZStephen Smith
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=956852021-08-02T14:09:01ZStephen Smith
<ul></ul><p>Changes at 065273b6a85d33939edad2b25efaf7028610e1e4 - branch 17681-relax-add-ssh-validation<br />Tests: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/453/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/453/">developer-tests-workbench2: #453 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=453" alt="" /></a></a></p>
Updated the ssh key validation regex to accept either (at the end of the key)
<ul>
<li>Original pattern which requires a single space and comment containing @<br />or</li>
<li>No whitespace at the end of the key</li>
</ul>
<p>Since the comment validation wasn't mentioned, I assume the existing behavior in requiring something@something is ok<br />Keys without a comment must not have any trailing whitespace or other characters (hopefully that's not too strict)</p> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=957122021-08-02T16:09:08ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><ul>
<li>Just one suggestion: Some unit tests could be easily added to check that <code>isRsaKey()</code> behaves correctly.</li>
</ul>
<p>With that, it LGTM.</p> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=957182021-08-02T18:29:42ZStephen Smith
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Added some tests and merged in fd49462a5a09e107b7bb5c0ef8635db328b399b8</p> Arvados Workbench 2 - Bug #17691: [Workbench2] the "add new ssh key" page does overly strict validationhttps://dev.arvados.org/issues/17691?journal_id=964582021-08-25T21:05:19ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>41</i></li></ul>