Project

General

Profile

Actions

Bug #17708

closed

[crunch-run] should be more tolerant of unsupported file types in the output directory

Added by Ward Vandewege about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
05/21/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Seeing a fatal error in a job, leading to no outputs being saved at all:

error in CaptureOutput: error scanning files to copy to output: Unsupported file type (mode 200000600) in output dir: "/var/spool/cwl/REDACTEDtmp/tmp.fifo.read1" 

That doesn't quite seem reasonable; if there are leftover fifos or named pipes, surely that should not make crunch-run error out. Printing a warning and just skipping the files of unsupported type in the copy job would be a better way to deal with this situation.


Subtasks 1 (0 open1 closed)

Task #17709: review 17708-crunch-run-unsupported-file-typesResolvedWard Vandewege05/21/2021

Actions
Actions #1

Updated by Ward Vandewege about 1 year ago

  • Status changed from New to In Progress
Actions #2

Updated by Ward Vandewege about 1 year ago

  • Description updated (diff)
Actions #3

Updated by Ward Vandewege about 1 year ago

  • Description updated (diff)
Actions #4

Updated by Ward Vandewege about 1 year ago

Ready for review at 7c5a4e0eb8529c7bf19a67ac85e52f61dff4ceb0 on branch 17708-crunch-run-unsupported-file-types

Tests are running at developer-run-tests: #2483

Actions #5

Updated by Ward Vandewege about 1 year ago

  • Description updated (diff)
Actions #6

Updated by Tom Clegg about 1 year ago

LGTM. I added a test:

17708-crunch-run-unsupported-file-types @ 250b93d70472dacb03400edc62d1d377aec342a2 -- developer-run-tests: #2484

Actions #7

Updated by Ward Vandewege about 1 year ago

Tom Clegg wrote:

LGTM. I added a test:

17708-crunch-run-unsupported-file-types @ 250b93d70472dacb03400edc62d1d377aec342a2 -- developer-run-tests: #2484

Thank you for the test, and the quick review! Merged.

Actions #8

Updated by Ward Vandewege about 1 year ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Ward Vandewege about 1 year ago

  • Release set to 38
Actions

Also available in: Atom PDF