Bug #17708
closed
[crunch-run] should be more tolerant of unsupported file types in the output directory
Description
Seeing a fatal error in a job, leading to no outputs being saved at all:
error in CaptureOutput: error scanning files to copy to output: Unsupported file type (mode 200000600) in output dir: "/var/spool/cwl/REDACTEDtmp/tmp.fifo.read1"
That doesn't quite seem reasonable; if there are leftover fifos or named pipes, surely that should not make crunch-run error out. Printing a warning and just skipping the files of unsupported type in the copy job would be a better way to deal with this situation.
Updated by Ward Vandewege almost 3 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege almost 3 years ago
Ready for review at 7c5a4e0eb8529c7bf19a67ac85e52f61dff4ceb0 on branch 17708-crunch-run-unsupported-file-types
Tests are running at developer-run-tests: #2483
Updated by Tom Clegg almost 3 years ago
LGTM. I added a test:
17708-crunch-run-unsupported-file-types @ 250b93d70472dacb03400edc62d1d377aec342a2 -- developer-run-tests: #2484
Updated by Ward Vandewege almost 3 years ago
Tom Clegg wrote:
LGTM. I added a test:
17708-crunch-run-unsupported-file-types @ 250b93d70472dacb03400edc62d1d377aec342a2 -- developer-run-tests: #2484
Thank you for the test, and the quick review! Merged.
Updated by Ward Vandewege almost 3 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|691bb7a4b5d2d2f30ce7c6914d6c6789e250658a.