Arvados

• I don't think we want to export IsErrorCapacity.
• The extra isCodeCapacity func seems needlessly verbose all for the sake of saving a few bytes of an unchanging map. Could just do var isCodeCapacity = map[string]bool{"InsufficientInstanceCapacity": true, ...}

• These errors seem more like quota errors than API request limit errors. We have a different interface for quota errors (IsQuotaError() bool), the Azure driver has an example. That way the dispatcher can shut down idle nodes in an effort to free up capacity.

Tom Clegg wrote:

For detecting the error:

• I don't think we want to export IsErrorCapacity.
• The extra isCodeCapacity func seems needlessly verbose all for the sake of saving a few bytes of an unchanging map. Could just do var isCodeCapacity = map[string]bool{"InsufficientInstanceCapacity": true, ...}

Yes, all fixed, thanks.

For reporting it back to dispatcher:

• These errors seem more like quota errors than API request limit errors. We have a different interface for quota errors (IsQuotaError() bool), the Azure driver has an example. That way the dispatcher can shut down idle nodes in an effort to free up capacity.

Thanks! I've updated the branch accordingly. I've also added a basic test for wrapError in the ec2 driver. See 6bb5a84a53e5810e96e56e41cc751d4ebc054580 on branch 17776-more-throttling.

Tests in developer-run-tests: #2527

LGTM, thanks!