arv-put --no-follow-links issues
A customer reported an incorrect behavior on the
arv-put command when used with
$ arv-put --no-follow-links /path/to/some-dir/
$ arv-put --no-follow-links /path/to/some-dir/*
Should produce the same collection, but if
/path/to/some-dir/ has some symbolic links inside, the second execution will not ignore them.
#2 Updated by Lucas Di Pentima 1 day ago
Updates at 96dc323b0 - branch
Test run: https://ci.arvados.org/job/developer-run-tests/2521/
- Fixes reported bug by ignoring symlinks (when requested) early in the upload list building process.
- Updates test.
Which behavior is "correct" seems debatable: it might be surprising that "arv-put --no-follow-symlinks foo" just creates an empty collection if foo itself is a symlink.
Perhaps worth adding something to the
--help message to clarify?
-Do not follow file and directory symlinks. +Do not follow file and directory symlinks. Even paths given explicitly on the command line will be skipped if they are symlinks.
#4 Updated by Lucas Di Pentima 1 day ago
Updates at 43e30e4be
Test run: https://ci.arvados.org/job/developer-run-tests/2525/
--helpdocumentation following the above suggestion.
- Logs warning when skipping a path that was specified by the user.
- Logs a warning when skipping saving an empty new collection.
- Adds test.