Remove josh_id / omniauth from rails API
Finally delete the SSO-login code path.
#3 Updated by Peter Amstutz 4 months ago
#4 Updated by Peter Amstutz 4 months ago
17829-remove-omniauth @ 5ade025ff305e91ec0238a0415b79f379e6d0157
Removed more SSO-related stuff
#7 Updated by Lucas Di Pentima 4 months ago
- Some tests are failing: https://ci.arvados.org/job/developer-run-tests/2551/
lib/config/config.default.yml- Line: 555 mentions SSO in a comment
lib/config/generated_config.goneeds updating, it has SSO entries.
doc/api/tokens_sso.html.textile.liquidis being included on the documentation. It has some other token-related information that may need relocation.
sdk/python/tests/run_test_server.pyhas now old SSO config sections that make
services/api/test/test_helper.rb-- Line 28: mentions omniauth's initializer
build/rails-package-scripts/arvados-api-server.sh-- Line 17 also mentions omniauth initializer
services/api/app/views/static/intro.html.erb-- Line 21 mentions
/auth/joshid. Also, that file mentions Curoverse in several places.
lib/controller/rpc/conn_test.go-- Line 55 has an assertion about the
#8 Updated by Peter Amstutz 4 months ago
17829-remove-omniauth @ 650df43af72632e22b7b99dfe7f55a1b5466e355
- Fix tests
- Fix a bunch of references to SSO or omniauth
#9 Updated by Peter Amstutz 4 months ago
#10 Updated by Peter Amstutz 4 months ago
#12 Updated by Peter Amstutz 4 months ago
Lucas Di Pentima wrote:
- Not wanting to scope creep but I've found more curoverse references at file
services/api/app/controllers/arvados/v1/schema_controller.rb, not sure what's the function of those scopes URLs.
I think the idea is that we would limit API calls based on OAuth2 scopes associated with the token. But we never did that (our token scopes behave completely differently). I'm pretty sure it isn't used by anything but also mostly unrelated to this ticket so I am not going to mess with it.
- Other than that, it LGTM