Story #17829

Remove josh_id / omniauth from rails API

Added by Peter Amstutz 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/23/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Finally delete the SSO-login code path.


Subtasks

Task #17831: Review 17829-remove-omniauthResolvedPeter Amstutz


Related issues

Related to Arvados - Bug #17828: bootsnap load error in arvboxResolved06/23/2021

Associated revisions

Revision 570e4e95
Added by Peter Amstutz 4 months ago

Merge branch '17829-remove-omniauth' refs #17829

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz 4 months ago

  • Related to Bug #17828: bootsnap load error in arvbox added

#5 Updated by Peter Amstutz 4 months ago

  • Description updated (diff)

#6 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2021-06-23 sprint to 2021-07-07 sprint

#7 Updated by Lucas Di Pentima 4 months ago

Reviewing 703bd34

  • Some tests are failing: https://ci.arvados.org/job/developer-run-tests/2551/
  • File lib/config/config.default.yml - Line: 555 mentions SSO in a comment
  • File lib/config/generated_config.go needs updating, it has SSO entries.
  • File doc/api/tokens_sso.html.textile.liquid is being included on the documentation. It has some other token-related information that may need relocation.
  • File sdk/python/tests/run_test_server.py has now old SSO config sections that make
  • File services/api/test/test_helper.rb -- Line 28: mentions omniauth's initializer
  • File build/rails-package-scripts/arvados-api-server.sh -- Line 17 also mentions omniauth initializer
  • File services/api/app/views/static/intro.html.erb -- Line 21 mentions /auth/joshid. Also, that file mentions Curoverse in several places.
  • File lib/controller/rpc/conn_test.go -- Line 55 has an assertion about the /auth/joshid callback.

#8 Updated by Peter Amstutz 4 months ago

17829-remove-omniauth @ 650df43af72632e22b7b99dfe7f55a1b5466e355

  • Fix tests
  • Fix a bunch of references to SSO or omniauth

https://ci.arvados.org/view/Developer/job/developer-run-tests/2552/

#11 Updated by Lucas Di Pentima 4 months ago

Reviewing b6d8769

  • Not wanting to scope creep but I've found more curoverse references at file services/api/app/controllers/arvados/v1/schema_controller.rb, not sure what's the function of those scopes URLs.
  • Other than that, it LGTM

#12 Updated by Peter Amstutz 4 months ago

Lucas Di Pentima wrote:

Reviewing b6d8769

  • Not wanting to scope creep but I've found more curoverse references at file services/api/app/controllers/arvados/v1/schema_controller.rb, not sure what's the function of those scopes URLs.

I think the idea is that we would limit API calls based on OAuth2 scopes associated with the token. But we never did that (our token scopes behave completely differently). I'm pretty sure it isn't used by anything but also mostly unrelated to this ticket so I am not going to mess with it.

  • Other than that, it LGTM

Thanks, merged.

#13 Updated by Peter Amstutz 4 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF