https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-07-07T14:31:03ZArvadosArvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=945042021-07-07T14:31:03ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><pre>
grep --color -nHr -e bundler
run-tests.sh:520: (bundle version | grep -q 2.0.2) || gem install bundler -v 2.0.2
run-tests.sh:523: "$bundle" version | grep 2.0.2 || fatal 'install bundler'
run-tests.sh:547: echo "Will install bundler and arvados gems to $tmpdir_gem_home"
run-tests.sh:552: bundlers="$(gem list --details bundler)"
run-tests.sh:555: if ! echo "$bundlers" | fgrep -q "($v)"; then
run-tests.sh:556: gem install --user $(for v in ${versions[@]}; do echo bundler:${v}; done)
run-tests.sh:561: ) || fatal 'install bundler'
rails-package-scripts/postinst.sh:202: run_and_report "Installing bundler" $COMMAND_PREFIX gem install bundler --version 1.17.3
package-build-dockerfiles/centos7/Dockerfile:19: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2 && \
package-build-dockerfiles/ubuntu2004/Dockerfile:24: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2 && \
package-build-dockerfiles/ubuntu1604/Dockerfile:24: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2 && \
package-build-dockerfiles/debian8/Dockerfile:26: /usr/local/rvm/bin/rvm-exec default gem install bundler && \
package-build-dockerfiles/debian10/Dockerfile:25: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2 && \
package-build-dockerfiles/ubuntu1804/Dockerfile:24: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2 && \
package-build-dockerfiles/ubuntu1404/Dockerfile:24: /usr/local/rvm/bin/rvm-exec default gem install bundler && \
package-test-dockerfiles/centos7/Dockerfile:20: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2
package-test-dockerfiles/ubuntu2004/Dockerfile:22: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2
package-test-dockerfiles/ubuntu1604/Dockerfile:22: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2
package-test-dockerfiles/debian10/Dockerfile:22: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2
package-test-dockerfiles/ubuntu1804/Dockerfile:22: /usr/local/rvm/bin/rvm-exec default gem install bundler --version 2.0.2
</pre>
<p>We support Ruby 2.7.2, the version of bundler associated with that seems to be 2.2.19.</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=945362021-07-07T15:43:38ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Ward Vandewege</i></li></ul> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=954102021-07-19T20:51:30ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=954132021-07-19T21:08:51ZWard Vandewegeward@curii.com
<ul></ul><p>Ready for review at <a class="changeset" title="17863: update to using bundler 2.2.19 everywhere. Arvados-DCO-1.1-Signed-off-by: Ward Vandewege ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/8e7674794c36d5baaf72486ca60b3e93aae83f0b">8e7674794c36d5baaf72486ca60b3e93aae83f0b</a> on branch 17863-bundler-update.</p>
<p>Tests have passed at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2591/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2591/">developer-run-tests: #2591 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2591" alt="" /></a></a>.</p>
<p>I've run the package build + test for Debian 10, CentOS 7, Ubuntu 18.04 and 20.04 locally, no errors.</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=954402021-07-21T13:53:17ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Ward Vandewege wrote:</p>
<blockquote>
<p>Ready for review at <a class="changeset" title="17863: update to using bundler 2.2.19 everywhere. Arvados-DCO-1.1-Signed-off-by: Ward Vandewege ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/8e7674794c36d5baaf72486ca60b3e93aae83f0b">8e7674794c36d5baaf72486ca60b3e93aae83f0b</a> on branch 17863-bundler-update.</p>
<p>Tests have passed at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2591/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2591/">developer-run-tests: #2591 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2591" alt="" /></a></a>.</p>
<p>I've run the package build + test for Debian 10, CentOS 7, Ubuntu 18.04 and 20.04 locally, no errors.</p>
</blockquote>
<p>LGTM</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=954422021-07-21T14:35:44ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>From discussion:</p>
<p>Rails has its own bin/bundle, so maybe we should be using that one instead of the system bundler?<br />We shouldn't run "bundle rails" we should just run "rails", it loads its own version of bundler ?</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=954692021-07-21T15:10:37ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-07-21 sprint</i> to <i>2021-08-04 sprint</i></li></ul> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=955362021-07-22T13:26:40ZWard Vandewegeward@curii.com
<ul></ul><p>Peter Amstutz wrote:</p>
<blockquote>
<p>From discussion:</p>
<p>Rails has its own bin/bundle, so maybe we should be using that one instead of the system bundler?<br />We shouldn't run "bundle rails" we should just run "rails", it loads its own version of bundler ?</p>
</blockquote>
<p>To be clear: rails 5 brought 'binstubs', like `bin/bundle` and `bin/rake` and `bin/rails`. They all load the right bundle environment and then call the correct command. The `bin/bundle` command still relies on (the correct version of) bundle to be present. As part of our `postinst.sh` script in the rails packages we install bundle 2.2.19 if bundle is not present.</p>
<p>I've pushed a commit that changes `bundle exec rake` to `bin/rake`, `bundle exec rails` to `bin/rails`, etc. Most of these were in the documentation (note that I did leave the old `bundle exec rake` calls alone in the upgrade guide, because those could be run from an older package that didn't have the binstubs yet). There were also a number of calls to `bundle exec rake` in the build scripts, which I have updated as well.</p>
<p>Ready for another look at <a class="changeset" title="17863: further cleanup in our rails postinst scripts and documentation: * replace `bundle exec` ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e3892bc5a88b810218ebdb564283e6f459ce4df3">e3892bc5a88b810218ebdb564283e6f459ce4df3</a>, which only changes the `build` and `doc` directories, package build/test passed at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/"<a href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/">developer-build-packages-multijob: #2 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-build-packages-multijob&build=2" alt="" /></a></a></p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=955382021-07-22T13:59:51ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Ward Vandewege wrote:</p>
<blockquote>
<p>Peter Amstutz wrote:</p>
<blockquote>
<p>From discussion:</p>
<p>Rails has its own bin/bundle, so maybe we should be using that one instead of the system bundler?<br />We shouldn't run "bundle rails" we should just run "rails", it loads its own version of bundler ?</p>
</blockquote>
<p>To be clear: rails 5 brought 'binstubs', like `bin/bundle` and `bin/rake` and `bin/rails`. They all load the right bundle environment and then call the correct command. The `bin/bundle` command still relies on (the correct version of) bundle to be present. As part of our `postinst.sh` script in the rails packages we install bundle 2.2.19 if bundle is not present.</p>
<p>I've pushed a commit that changes `bundle exec rake` to `bin/rake`, `bundle exec rails` to `bin/rails`, etc. Most of these were in the documentation (note that I did leave the old `bundle exec rake` calls alone in the upgrade guide, because those could be run from an older package that didn't have the binstubs yet). There were also a number of calls to `bundle exec rake` in the build scripts, which I have updated as well.</p>
</blockquote>
<p>The changes to doc/README.textile don't seem right. That's describing how to build the docs themselves, not how to run Arvados. The docs use their own Gemfile / version of rake which is entirely separate from Rails, I don't know if it makes sense to use the binstub in this case.</p>
<blockquote>
<p>Ready for another look at <a class="changeset" title="17863: further cleanup in our rails postinst scripts and documentation: * replace `bundle exec` ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e3892bc5a88b810218ebdb564283e6f459ce4df3">e3892bc5a88b810218ebdb564283e6f459ce4df3</a>, which only changes the `build` and `doc` directories, package build/test passed at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/"<a href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/">developer-build-packages-multijob: #2 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-build-packages-multijob&build=2" alt="" /></a></a></p>
</blockquote>
<p>The rest of this LGTM.</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=955422021-07-22T14:28:58ZWard Vandewegeward@curii.com
<ul></ul><p>Peter Amstutz wrote:</p>
<blockquote>
<p>Ward Vandewege wrote:</p>
<blockquote>
<p>Peter Amstutz wrote:</p>
<blockquote>
<p>From discussion:</p>
<p>Rails has its own bin/bundle, so maybe we should be using that one instead of the system bundler?<br />We shouldn't run "bundle rails" we should just run "rails", it loads its own version of bundler ?</p>
</blockquote>
<p>To be clear: rails 5 brought 'binstubs', like `bin/bundle` and `bin/rake` and `bin/rails`. They all load the right bundle environment and then call the correct command. The `bin/bundle` command still relies on (the correct version of) bundle to be present. As part of our `postinst.sh` script in the rails packages we install bundle 2.2.19 if bundle is not present.</p>
<p>I've pushed a commit that changes `bundle exec rake` to `bin/rake`, `bundle exec rails` to `bin/rails`, etc. Most of these were in the documentation (note that I did leave the old `bundle exec rake` calls alone in the upgrade guide, because those could be run from an older package that didn't have the binstubs yet). There were also a number of calls to `bundle exec rake` in the build scripts, which I have updated as well.</p>
</blockquote>
<p>The changes to doc/README.textile don't seem right. That's describing how to build the docs themselves, not how to run Arvados. The docs use their own Gemfile / version of rake which is entirely separate from Rails, I don't know if it makes sense to use the binstub in this case.</p>
</blockquote>
<p>Right! I've reverted the changes to this file.</p>
<blockquote><blockquote>
<p>Ready for another look at <a class="changeset" title="17863: further cleanup in our rails postinst scripts and documentation: * replace `bundle exec` ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e3892bc5a88b810218ebdb564283e6f459ce4df3">e3892bc5a88b810218ebdb564283e6f459ce4df3</a>, which only changes the `build` and `doc` directories, package build/test passed at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/"<a href="https://ci.arvados.org/view/Developer/job/developer-build-packages-multijob/2/">developer-build-packages-multijob: #2 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-build-packages-multijob&build=2" alt="" /></a></a></p>
</blockquote>
<p>The rest of this LGTM.</p>
</blockquote>
<p>Thanks, merged as <a class="changeset" title="17863: further cleanup in our rails postinst scripts and documentation: * replace `bundle exec` ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/32e1a62223130822eaac3ebdef942a44102184b9">32e1a62223130822eaac3ebdef942a44102184b9</a> which reverts the changes to doc/README.textile.</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=955442021-07-22T14:46:00ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '17863-bundler-update' closes #17863 Arvados-DCO-1.1-Signed-off-by: Ward Vandewege..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e1cee0a8ebb0728bcb62e89530c11ea8dc072371">arvados|e1cee0a8ebb0728bcb62e89530c11ea8dc072371</a>.</p> Arvados - Bug #17863: Use bundler 2.2.19 consistentlyhttps://dev.arvados.org/issues/17863?journal_id=985772021-11-16T16:28:23ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>42</i></li></ul>