Bug #17952

[workbench] Remove unused "compute nodes" UX (admin dropdown)

Added by Ward Vandewege about 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/04/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This feature is unused since we retired node manager.


Subtasks

Task #17977: Review 17952-no-nodes-linkResolvedPeter Amstutz


Related issues

Blocks Arvados - Bug #17953: [api] Remove unused "node" objectNew

Associated revisions

Revision 3787b0ae
Added by Peter Amstutz about 2 months ago

Merge branch '17952-no-nodes-link' into main closes #17952

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Ward Vandewege about 2 months ago

  • Release set to 41
  • Description updated (diff)
  • Subject changed from [workbench] Remove unused compute nodes UX to [workbench] Remove unused "compute nodes" UX (admin dropdown)

#2 Updated by Ward Vandewege about 2 months ago

  • Blocks Bug #17953: [api] Remove unused "node" object added

#3 Updated by Ward Vandewege about 2 months ago

  • Target version set to 2021-08-18 sprint

#4 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-08-18 sprint to 2021-09-01 sprint

#5 Updated by Peter Amstutz about 2 months ago

  • Target version changed from 2021-09-01 sprint to 2021-08-18 sprint

#6 Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Peter Amstutz

#7 Updated by Peter Amstutz about 2 months ago

17952-no-nodes-link @ b5b64f5dcc4fa4614002e5a0969adba36ac7e5e8

Remove links to obsolete /nodes and /keep_disks pages.

https://ci.arvados.org/view/Developer/job/developer-run-tests/2618/

#8 Updated by Lucas Di Pentima about 2 months ago

There's a wb1 integration test failing with the following log:

21:59:24   3) Error:
21:59:24 ApplicationLayoutTest#test_test_system_menu_Keep_disks_link:
21:59:24 Capybara::ExpectationNotMet: expected to find css "a" with text "Keep disks" but there were no matches. Also found "Repositories", "Virtual machines", "SSH keys", "API tokens", "Links", "Users", "Groups", "Keep services", which matched the selector but not all filters.
21:59:24     test/integration/application_layout_test.rb:263:in `block (4 levels) in <class:ApplicationLayoutTest>'
21:59:24     test/integration/application_layout_test.rb:262:in `block (3 levels) in <class:ApplicationLayoutTest>'
21:59:24     test/integration/application_layout_test.rb:260:in `block (2 levels) in <class:ApplicationLayoutTest>'
21:59:24     test/test_helper.rb:358:in `capture_exceptions'
21:59:24     test/test_helper.rb:285:in `run'

Maybe this one isn't an intermittent failure.

#9 Updated by Peter Amstutz about 2 months ago

Yea, that was a fire-and-forget test run, I didn't check it. Unsurprisingly the tests to check if those exact menu items were present failed, since they are no longer present. Removed them from the test list.

17952-no-nodes-link @ 3460f961868a965129edcf0947c69a7829a47a67

https://ci.arvados.org/view/Developer/job/developer-run-tests/2619/

#10 Updated by Lucas Di Pentima about 2 months ago

This LGTM, thanks!

#11 Updated by Peter Amstutz about 2 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

Also available in: Atom PDF