Project

General

Profile

Actions

Bug #17982

closed

Recent searches / saved searches should show up when clicking on search bar not after entering and then deleting input

Added by Peter Amstutz about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #17992: Review 17982-recent-saved-searches-display-bugResolvedLucas Di Pentima08/10/2021Actions
Actions #1

Updated by Stephen Smith about 3 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Stephen Smith about 3 years ago

Changes on arvados-workbench2|1f1c5dbbad160ef2cc7dc0a2cd736fefd5025d1e branch 17982-recent-saved-searches-display-bug
Tests developer-tests-workbench2: #457

Actions #3

Updated by Lucas Di Pentima about 3 years ago

Fixed the integration tests' cluster config to match the new storage classes config requirements at arvados-workbench2|4da9314a
Test run: developer-tests-workbench2: #462

Actions #4

Updated by Lucas Di Pentima about 3 years ago

I've found one additional issue: If you already have some saved searches, they seem to not be loaded at app boot time because when I click on the search box the "saved queries" list is empty, and then when I save a new one, all the rest start to appear.

Actions #5

Updated by Stephen Smith about 3 years ago

Thanks, I added the call to openSearchView to the empty search box code path and that fixes the issue - the only other change in behavior is that the first item is now selected automatically for both the empty and non-empty case in the onclick handler. Let me know what you think

Commit arvados-workbench2|e31bd3f0af6e0b3d4166af144ef8aed5d110b5af
Tests developer-tests-workbench2: #463

Actions #6

Updated by Lucas Di Pentima about 3 years ago

Stephen Smith wrote:

Thanks, I added the call to openSearchView to the empty search box code path and that fixes the issue - the only other change in behavior is that the first item is now selected automatically for both the empty and non-empty case in the onclick handler. Let me know what you think

I think it doesn't create a problem, this look good to merge, thanks!

Actions #7

Updated by Stephen Smith about 3 years ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz about 3 years ago

  • Release set to 41
Actions

Also available in: Atom PDF