Bug #17982

Recent searches / saved searches should show up when clicking on search bar not after entering and then deleting input

Added by Peter Amstutz about 2 months ago. Updated 30 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
08/10/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #17992: Review 17982-recent-saved-searches-display-bugResolvedLucas Di Pentima

Associated revisions

Revision 266f22d3
Added by Stephen Smith about 1 month ago

Merge branch '17982-recent-saved-searches-display-bug' into main. Closes #17982

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <>

History

#1 Updated by Stephen Smith about 2 months ago

  • Status changed from New to In Progress

#3 Updated by Lucas Di Pentima about 1 month ago

Fixed the integration tests' cluster config to match the new storage classes config requirements at arvados-workbench2|4da9314a
Test run: https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/462/

#4 Updated by Lucas Di Pentima about 1 month ago

I've found one additional issue: If you already have some saved searches, they seem to not be loaded at app boot time because when I click on the search box the "saved queries" list is empty, and then when I save a new one, all the rest start to appear.

#5 Updated by Stephen Smith about 1 month ago

Thanks, I added the call to openSearchView to the empty search box code path and that fixes the issue - the only other change in behavior is that the first item is now selected automatically for both the empty and non-empty case in the onclick handler. Let me know what you think

Commit arvados-workbench2|e31bd3f0af6e0b3d4166af144ef8aed5d110b5af
Tests https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/463/

#6 Updated by Lucas Di Pentima about 1 month ago

Stephen Smith wrote:

Thanks, I added the call to openSearchView to the empty search box code path and that fixes the issue - the only other change in behavior is that the first item is now selected automatically for both the empty and non-empty case in the onclick handler. Let me know what you think

I think it doesn't create a problem, this look good to merge, thanks!

#7 Updated by Stephen Smith about 1 month ago

  • Status changed from In Progress to Resolved

#8 Updated by Peter Amstutz 30 days ago

  • Release set to 41

Also available in: Atom PDF