Project

General

Profile

Actions

Bug #17984

closed

--project-uuid validation should accept user uuids (regression)

Added by Peter Amstutz over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
CWL
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #17986: Review 17984-cwl-project-uuid-usersResolvedPeter Amstutz08/10/2021Actions
Actions #1

Updated by Peter Amstutz over 2 years ago

  • Release set to 41
Actions #2

Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Peter Amstutz over 2 years ago

17984-cwl-project-uuid-users @ 74aa79ebb951a915a8f5aba49852a0119835c579

Validation recognizes user uuids.

Also add check that groups are projects.

Also improves error reporting to avoid a back trace in this case when not run with --debug.

Actions #4

Updated by Lucas Di Pentima over 2 years ago

Some comments:

  • The api().users().get(uuid=xxxx).execute() call I believe is meant to check if the current user has access to the tpzed-type UUID. Wouldn't it be more correct to just compare if the UUID is the same as the current user's UUID or is there a case where a user would submit a workflow on another user's home project?
  • Some tests are failing at: developer-run-tests-remainder: #2731 /console
Actions #5

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

Some comments:

  • The api().users().get(uuid=xxxx).execute() call I believe is meant to check if the current user has access to the tpzed-type UUID. Wouldn't it be more correct to just compare if the UUID is the same as the current user's UUID or is there a case where a user would submit a workflow on another user's home project?

Technically an admin could assign the workflow run to be owned by another user. It might not really make sense but at the same time I don't see a benefit to forbidding it.

Fixed

17984-cwl-project-uuid-users @ 1521969d1475ab6854d1f9987fdaa1f66a1cbaab

developer-run-tests: #2637

Actions #6

Updated by Lucas Di Pentima over 2 years ago

This LGTM, thanks.

Actions #7

Updated by Peter Amstutz over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF