Feature #18001

[api] add Users/UserNotifierEmailBcc config option

Added by Ward Vandewege about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/13/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #18007: review 18001-add-UserNotifierEmailBccResolvedWard Vandewege

Associated revisions

Revision e1d178af
Added by Ward Vandewege about 1 month ago

Merge branch '18001-add-UserNotifierEmailBcc'

closes #18001

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Ward Vandewege about 1 month ago

  • Status changed from New to In Progress

#2 Updated by Ward Vandewege about 1 month ago

  • Target version set to 2021-08-18 sprint

#3 Updated by Ward Vandewege about 1 month ago

Ready for review at 89f8175850a9279036053b2a6785980a479e08d8 on branch 18001-add-UserNotifierEmailBcc

Tests ran at https://ci.arvados.org/view/Developer/job/developer-run-tests/2631/. The wb functionals had an unrelated failure, it passed when re-run at https://ci.arvados.org/job/developer-run-tests-apps-workbench-functionals/2673/.

#4 Updated by Ward Vandewege about 1 month ago

  • Release set to 41

#5 Updated by Peter Amstutz about 1 month ago

arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash, ->(cfg, k, v) { arrayToHash cfg, "Users.UserNotifierEmailBcc", v }

The ->(cfg, k, v) {...} part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:

arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash

The rest LGTM

#6 Updated by Ward Vandewege about 1 month ago

Peter Amstutz wrote:

[...]

The ->(cfg, k, v) {...} part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:

[...]

The rest LGTM

Great thanks, merged with that change.

#7 Updated by Ward Vandewege about 1 month ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF