Project

General

Profile

Actions

Feature #18001

closed

[api] add Users/UserNotifierEmailBcc config option

Added by Ward Vandewege 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/13/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #18007: review 18001-add-UserNotifierEmailBccResolvedWard Vandewege08/13/2021

Actions
Actions #1

Updated by Ward Vandewege 11 months ago

  • Status changed from New to In Progress
Actions #2

Updated by Ward Vandewege 11 months ago

  • Target version set to 2021-08-18 sprint
Actions #3

Updated by Ward Vandewege 11 months ago

Ready for review at 89f8175850a9279036053b2a6785980a479e08d8 on branch 18001-add-UserNotifierEmailBcc

Tests ran at developer-run-tests: #2631 . The wb functionals had an unrelated failure, it passed when re-run at developer-run-tests-apps-workbench-functionals: #2673 .

Actions #4

Updated by Ward Vandewege 11 months ago

  • Release set to 41
Actions #5

Updated by Peter Amstutz 11 months ago

arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash, ->(cfg, k, v) { arrayToHash cfg, "Users.UserNotifierEmailBcc", v }

The ->(cfg, k, v) {...} part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:

arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash

The rest LGTM

Actions #6

Updated by Ward Vandewege 11 months ago

Peter Amstutz wrote:

[...]

The ->(cfg, k, v) {...} part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:

[...]

The rest LGTM

Great thanks, merged with that change.

Actions #7

Updated by Ward Vandewege 11 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF