https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-08-10T14:54:43ZArvadosArvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=960202021-08-10T14:54:43ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=960212021-08-10T14:54:56ZWard Vandewegeward@curii.com
<ul><li><strong>Target version</strong> set to <i>2021-08-18 sprint</i></li></ul> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=960812021-08-11T14:56:26ZWard Vandewegeward@curii.com
<ul></ul><p>Ready for review at <a class="changeset" title="18001: add Users/UserNotifierEmailBcc configuration option, which is the e-mail address th..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/89f8175850a9279036053b2a6785980a479e08d8">89f8175850a9279036053b2a6785980a479e08d8</a> on branch 18001-add-UserNotifierEmailBcc</p>
<p>Tests ran at <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2631/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2631/">developer-run-tests: #2631 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2631" alt="" /></a></a>. The wb functionals had an unrelated failure, it passed when re-run at <a class="external" href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-functionals/2673/"<a href="https://ci.arvados.org/job/developer-run-tests-apps-workbench-functionals/2673/">developer-run-tests-apps-workbench-functionals: #2673 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests-apps-workbench-functionals&build=2673" alt="" /></a></a>.</p> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=960832021-08-11T14:56:51ZWard Vandewegeward@curii.com
<ul><li><strong>Release</strong> set to <i>41</i></li></ul> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=962002021-08-13T19:22:12ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><pre>
arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash, ->(cfg, k, v) { arrayToHash cfg, "Users.UserNotifierEmailBcc", v }
</pre>
<p>The <code>->(cfg, k, v) {...}</code> part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:</p>
<pre>
arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash
</pre>
<p>The rest LGTM</p> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=962022021-08-13T19:35:48ZWard Vandewegeward@curii.com
<ul></ul><p>Peter Amstutz wrote:</p>
<blockquote>
<p>[...]</p>
<p>The <code>->(cfg, k, v) {...}</code> part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:</p>
<p>[...]</p>
<p>The rest LGTM</p>
</blockquote>
<p>Great thanks, merged with that change.</p> Arvados - Feature #18001: [api] add Users/UserNotifierEmailBcc config optionhttps://dev.arvados.org/issues/18001?journal_id=962042021-08-13T19:36:16ZWard Vandewegeward@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '18001-add-UserNotifierEmailBcc' closes #18001 Arvados-DCO-1.1-Signed-off-by: Ward..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/e1d178affae6eb4c8a09deafa0b980b3f440b278">arvados|e1d178affae6eb4c8a09deafa0b980b3f440b278</a>.</p>