Bug #18021

Fix flaky keepstore test

Added by Peter Amstutz 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
09/01/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Keepstore test failed on a branch changing an unrelated thing:

https://ci.arvados.org/job/developer-run-tests-remainder/2744/console


Subtasks

Task #18081: Review note-4ResolvedLucas Di Pentima

History

#1 Updated by Peter Amstutz 2 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 2 months ago

  • Target version changed from 2021-09-01 sprint to 2021-09-15 sprint

#3 Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Tom Clegg

#4 Updated by Tom Clegg about 2 months ago

  • Status changed from New to In Progress

This was already fixed incidentally in #17698 by changing (*RRVolumeManager)AllReadable() to return volumes sorted by priority and then UUID, instead of indeterminate order as before. The index handler processes the volumes in the same order AllReadable() returns them, so the test is now reliable.

Test results today:

32x at 87b0f117ff1ce917d7301f8a6304e931a189e48d (version jenkins tested in the given example) → 6 failures

32x at 2c2153daa103c35fe12468a853636f8125785a7e (head of main branch today) → 0 failures

#5 Updated by Lucas Di Pentima about 2 months ago

Looks good to mark as resolved :)

#6 Updated by Tom Clegg about 2 months ago

  • Status changed from In Progress to Resolved

#7 Updated by Tom Clegg about 2 months ago

  • Status changed from Resolved to In Progress

Another one still happening on main:

https://ci.arvados.org/job/run-tests-remainder/4859/consoleFull

FAIL: mounts_test.go:21: HandlerSuite.TestMounts

#8 Updated by Tom Clegg about 2 months ago

Doh. Fixed by sorting vm.mounts the same way as vm.readables and vm.writables. This time I checked that all keepstore tests pass 32x in a row.

18021-sort-mounts @ a385021d2822454e7f563decb6f8f00d0c4a1ca4 -- https://ci.arvados.org/view/Developer/job/developer-run-tests/2679/

#9 Updated by Tom Clegg about 2 months ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|47e60671196e91dea0b99a2c4496ce0fdc683852.

Also available in: Atom PDF