Project

General

Profile

Actions

Bug #18029

closed

NaN paging for Public Favorites when you click on the next page arrow on an empty data table

Added by Peter Amstutz over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
09/10/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

The problem can be reproduced by logging in on ce8i5's wb2, going to the "Public Favorites" section, and clicking on the "next page" icon at the bottom of the panel.


Files

NaN pages.png (175 KB) NaN pages.png Lucas Di Pentima, 08/18/2021 07:49 PM
NaN pages after clicking.png (201 KB) NaN pages after clicking.png Lucas Di Pentima, 08/18/2021 07:49 PM

Subtasks 1 (0 open1 closed)

Task #18031: ReviewResolvedStephen Smith09/10/2021

Actions
Actions #2

Updated by Lucas Di Pentima over 1 year ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz over 1 year ago

  • Assigned To set to Daniel Kutyła
Actions #5

Updated by Peter Amstutz over 1 year ago

  • Target version changed from 2021-09-01 sprint to 2021-09-15 sprint
Actions #6

Updated by Peter Amstutz over 1 year ago

  • Assigned To changed from Daniel Kutyła to Stephen Smith
Actions #7

Updated by Stephen Smith over 1 year ago

Changes at arvados-workbench2|e983d1cc16a370a1cf0ab3dccc47049a34ef049d branch 18029-fix-nan-pagination
Tests developer-tests-workbench2: #477

  • Fixed dividing by 0 in pagination in multiple places
  • Added a conditional disable to the next button on DataExplorer since mui pagination's default behavior seems to be not doing that automatically when there are no items
Actions #8

Updated by Stephen Smith over 1 year ago

  • Status changed from New to In Progress
Actions #9

Updated by Lucas Di Pentima over 1 year ago

Just one suggestion/question:

  • Do you think it would be better to resolve the "division by 0" issue on the reducer instead so that it's done just in one place?

Other than that, it LGTM.

Actions

Also available in: Atom PDF