Actions
Bug #18029
closed
NaN paging for Public Favorites when you click on the next page arrow on an empty data table
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Description
The problem can be reproduced by logging in on ce8i5's wb2, going to the "Public Favorites" section, and clicking on the "next page" icon at the bottom of the panel.
Files
Updated by Lucas Di Pentima over 2 years ago
- File NaN pages after clicking.png NaN pages after clicking.png added
- File NaN pages.png NaN pages.png added
Updated by Peter Amstutz over 2 years ago
- Target version changed from 2021-09-01 sprint to 2021-09-15 sprint
Updated by Peter Amstutz over 2 years ago
- Assigned To changed from Daniel Kutyła to Stephen Smith
Updated by Stephen Smith over 2 years ago
Changes at arvados-workbench2|e983d1cc16a370a1cf0ab3dccc47049a34ef049d branch 18029-fix-nan-pagination
Tests developer-tests-workbench2: #477
- Fixed dividing by 0 in pagination in multiple places
- Added a conditional disable to the next button on DataExplorer since mui pagination's default behavior seems to be not doing that automatically when there are no items
Updated by Stephen Smith over 2 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 2 years ago
Just one suggestion/question:
- Do you think it would be better to resolve the "division by 0" issue on the reducer instead so that it's done just in one place?
Other than that, it LGTM.
Updated by Stephen Smith over 2 years ago
- Status changed from In Progress to Resolved
Actions