Project

General

Profile

Actions
Copy link

Bug #18075

closed

arvados-dispatch-cloud should respect Containers.MaxComputeVMs

Added by Peter Amstutz over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Crunch
Target version:
2023-02-15 sprint
Story points:
1.0
Release:
Arvados 2.6.0
Release relationship:
Auto

Description

While researching a customer question, I noticed that we have a config setting Containers.MaxComputeVMs which is not respected by arvados-dispatch-cloud. (It appears that it was previously used by the legacy "nodes" table and NodeManager). We should rename it to MaxInstances in the CloudVMs section and support it so users have a way to avoid blowing up their Arvados cluster by accident when they queue a really large workflow.

Subtasks 1 (0 open — 1 closed)

Task #19944: Review 18075-max-compute-vmsResolvedTom Clegg01/31/2023Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz almost 2 years ago

  • Target version set to Future
Actions
Copy link
 #3

Updated by Peter Amstutz almost 2 years ago

  • Target version deleted (Future)
  • Description updated (diff)
Actions
Copy link
 #4

Updated by Peter Amstutz almost 2 years ago

  • Target version set to Future
Actions
Copy link
 #5

Updated by Tom Clegg almost 2 years ago

  • Story points set to 1.0
  • Target version changed from Future to To be scheduled
  • Assigned To set to Tom Clegg
  • Description updated (diff)
Actions
Copy link
 #6

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from To be scheduled to 2023-02-01 sprint
Actions
Copy link
 #7

Updated by Peter Amstutz almost 2 years ago

  • Release set to 57
Actions
Copy link
 #8

Updated by Tom Clegg almost 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #9

Updated by Tom Clegg almost 2 years ago

Actions
Copy link
 #10

Updated by Tom Clegg almost 2 years ago

18075-max-compute-vms @ c11aeb6b640c78feec50ebcacc52718faf5643a7 -- developer-run-tests: #3469

retry wb1 developer-run-tests-apps-workbench-integration: #3731

  • add new config CloudVMs.MaxInstances (behaves the same as hitting cloud provider's instance quota)
  • remove old config to avoid confusion
  • eye-poke tests that rely on old config (I wondered if I could remove the database table or the railsapi routes/code, but it quickly started affecting Everything, so I backed away slowly)
Actions
Copy link
 #11

Updated by Lucas Di Pentima almost 2 years ago

The code LGTM, just a couple of comments on documentation:

  • The code comment for AtQuota() might need some update to reflect the new behavior.
  • The upgrade notes could also mention the deprecated config knob.
Actions
Copy link
 #12

Updated by Peter Amstutz almost 2 years ago

  • Target version changed from 2023-02-01 sprint to 2023-02-15 sprint
Actions
Copy link
 #13

Updated by Tom Clegg almost 2 years ago

18075-max-compute-vms @ b4b146dd2d1e8c816def4216951654f60fd8349f -- developer-run-tests: #3471
  • mention deprecated config in upgrade notes
  • update AtQuota comment
  • check quota at time of Create() too
Actions
Copy link
 #14

Updated by Lucas Di Pentima almost 2 years ago

Thanks, LGTM.

Actions
Copy link
 #15

Updated by Tom Clegg almost 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF