Feature #18113

[a-d-c] non-zero defaults for MaxCloudOpsPerSecond and MaxConcurrentInstanceCreateOps

Added by Tom Clegg about 2 months ago. Updated 19 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
10/05/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Instead of 0 (unlimited) we could start with values that are reasonable for a normal size production cluster / typical cloud account.

MaxConcurrentInstanceCreateOps was invented to accommodate Azure limitations, but now that we have it, we might as well promote using it as a guard rail for all cloud providers.

Perhaps 10 ops per second and 1 concurrent create op. Recommend raising to 20 concurrent create ops for Azure since it doesn't return the "create" response until the instance has booted.


Subtasks

Task #18222: ReviewResolvedTom Clegg


Related issues

Related to Arvados - Bug #18102: max dispatch attempts errorResolved09/07/2021

Associated revisions

Revision 4a75fdce
Added by Ward Vandewege 19 days ago

Merge branch '18113-change-cloudops-defaults'

closes #18113

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Tom Clegg about 2 months ago

  • Tracker changed from Story to Feature

#2 Updated by Tom Clegg about 2 months ago

  • Description updated (diff)

#3 Updated by Tom Clegg about 2 months ago

  • Related to Bug #18102: max dispatch attempts error added

#4 Updated by Tom Clegg about 1 month ago

  • Description updated (diff)

#5 Updated by Ward Vandewege about 1 month ago

  • Target version set to 2021-10-13 sprint

#6 Updated by Peter Amstutz 28 days ago

  • Release set to 42

#7 Updated by Peter Amstutz 27 days ago

  • Assigned To set to Ward Vandewege

#8 Updated by Ward Vandewege 27 days ago

  • Status changed from New to In Progress

Ready for review in 1e8b4a7843b63a418aca83e8dd0a24c0ce52a522 on branch 18113-change-cloudops-defaults.

Tests running at https://ci.arvados.org/view/Developer/job/developer-run-tests/2717/

#9 Updated by Tom Clegg 27 days ago

The two comments on MaxConcurrentInstanceCreateOps read a bit strange. Perhaps the "recommended by Azure" & azure docs link should move to the 2nd paragraph and the "can be used with other cloud providers too, if desired" bit in the first paragraph can be removed entirely?

The old comment says "node creation", while we're here I think it would be more consistent to change that to "instance creation".

Besides that, LGTM

#10 Updated by Peter Amstutz 27 days ago

Ward Vandewege wrote:

Ready for review in 1e8b4a7843b63a418aca83e8dd0a24c0ce52a522 on branch 18113-change-cloudops-defaults.

Tests running at https://ci.arvados.org/view/Developer/job/developer-run-tests/2717/

I know Tom took the review but I saw the commit message go past and I looked at it.

The comments don't really explain the difference/relationship between MaxCloudOpsPerSecond and MaxConcurrentInstanceCreateOps.

#11 Updated by Ward Vandewege 19 days ago

I've addressed both reviewers' comments in eb29c5471bdface71362af6f4e6a669d0da8d346 on branch 18113-change-cloudops-defaults. Does that look better?

#12 Updated by Tom Clegg 19 days ago

Yes, I think that addresses all concerns. LGTM.

#13 Updated by Ward Vandewege 19 days ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Also available in: Atom PDF