Feature #18113
closed
[a-d-c] non-zero defaults for MaxCloudOpsPerSecond and MaxConcurrentInstanceCreateOps
Description
Instead of 0 (unlimited) we could start with values that are reasonable for a normal size production cluster / typical cloud account.
MaxConcurrentInstanceCreateOps was invented to accommodate Azure limitations, but now that we have it, we might as well promote using it as a guard rail for all cloud providers.
Perhaps 10 ops per second and 1 concurrent create op. Recommend raising to 20 concurrent create ops for Azure since it doesn't return the "create" response until the instance has booted.
Related issues
Updated by Tom Clegg over 2 years ago
- Related to Bug #18102: max dispatch attempts error added
Updated by Ward Vandewege over 2 years ago
- Target version set to 2021-10-13 sprint
Updated by Ward Vandewege over 2 years ago
- Status changed from New to In Progress
Ready for review in 1e8b4a7843b63a418aca83e8dd0a24c0ce52a522 on branch 18113-change-cloudops-defaults.
Tests running at developer-run-tests: #2717
Updated by Tom Clegg over 2 years ago
The two comments on MaxConcurrentInstanceCreateOps read a bit strange. Perhaps the "recommended by Azure" & azure docs link should move to the 2nd paragraph and the "can be used with other cloud providers too, if desired" bit in the first paragraph can be removed entirely?
The old comment says "node creation", while we're here I think it would be more consistent to change that to "instance creation".
Besides that, LGTM
Updated by Peter Amstutz over 2 years ago
Ward Vandewege wrote:
Ready for review in 1e8b4a7843b63a418aca83e8dd0a24c0ce52a522 on branch 18113-change-cloudops-defaults.
Tests running at developer-run-tests: #2717
I know Tom took the review but I saw the commit message go past and I looked at it.
The comments don't really explain the difference/relationship between MaxCloudOpsPerSecond and MaxConcurrentInstanceCreateOps.
Updated by Ward Vandewege over 2 years ago
I've addressed both reviewers' comments in eb29c5471bdface71362af6f4e6a669d0da8d346 on branch 18113-change-cloudops-defaults. Does that look better?
Updated by Tom Clegg over 2 years ago
Yes, I think that addresses all concerns. LGTM.
Updated by Ward Vandewege over 2 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados|4a75fdcef8c86aebf478801b81fd9770f79a34a7.