https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-09-13T20:14:54ZArvadosArvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=969732021-09-13T20:14:54ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/96973/diff?detail_id=93622">diff</a>)</li><li><strong>Subject</strong> changed from <i>Support 'select' on update calls to limit what fields are returned in update response</i> to <i>Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update response</i></li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=969742021-09-13T20:57:39ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>For the 'get' case, would it be useful to have a 'deselect' param so that we don't need to update clients (e.g., wb2) when new fields are added to collections while avoiding getting the <code>manifest_text</code> included in the response?</p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=970212021-09-14T19:46:58ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/97021/diff?detail_id=93672">diff</a>)</li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=970222021-09-14T19:47:09ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2021-09-29 sprint</i></li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=970232021-09-14T19:48:40ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/97023/diff?detail_id=93674">diff</a>)</li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=970772021-09-15T15:10:01ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971112021-09-16T13:18:06ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971242021-09-16T14:56:25ZTom Cleggtom@curii.com
<ul></ul><p>18122-select-param @ <a class="changeset" title="18122: Update "distinct" docs (default is false) and tidy up code. Arvados-DCO-1.1-Signed-off-by..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/5d7bef4122c59bec9145f2853b76170b4ddca67f">5d7bef4122c59bec9145f2853b76170b4ddca67f</a> -- <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2692/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2692/">developer-run-tests: #2692 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2692" alt="" /></a></a></p>
<p>Confirmed that only the selected columns are loaded from the database (except in the case of "update", which needs to populate all attributes in order to do validations).</p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971302021-09-16T17:23:36ZTom Cleggtom@curii.com
<ul></ul><p>18122-select-param @ <a class="changeset" title="18122: Fix "get collection by pdh" when manifest_text is unselected. Arvados-DCO-1.1-Signed-off-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/7563e6276baade41eb3faa3ff167abab1cb0f890">7563e6276baade41eb3faa3ff167abab1cb0f890</a> -- <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2694/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2694/">developer-run-tests: #2694 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2694" alt="" /></a></a></p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971342021-09-16T19:18:26ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Here're my comments/questions:</p>
<ul>
<li>In file <code>services/api/app/controllers/application_controller.rb</code>: In the <code>_requires_parameters</code> methods, should descriptions be added for the automatic cli help?</li>
<li>Word repetition in file <code>doc/api/methods.html.textile.liquid:L87</code>: "...whose whose..." </li>
<li>Do you think it would be helpful to document the particular behavior when requesting a collection by PDH? (i.e., we can use <code>select</code> to "deselect" <code>manifest_text</code>)</li>
</ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971612021-09-20T14:01:41ZTom Cleggtom@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<ul>
<li>In file <code>services/api/app/controllers/application_controller.rb</code>: In the <code>_requires_parameters</code> methods, should descriptions be added for the automatic cli help?</li>
</ul>
</blockquote>
<p>Good point, added</p>
<blockquote>
<ul>
<li>Word repetition in file <code>doc/api/methods.html.textile.liquid:L87</code>: "...whose whose..."</li>
</ul>
</blockquote>
<p>Fixed, thanks</p>
<blockquote>
<ul>
<li>Do you think it would be helpful to document the particular behavior when requesting a collection by PDH? (i.e., we can use <code>select</code> to "deselect" <code>manifest_text</code>)</li>
</ul>
</blockquote>
<p>Updated the relevant part of the api/methods/collections page -- is this better?</p>
<p>18122-select-param @ <a class="changeset" title="18122: Clarify select param behavior in "get collection by pdh" API. Arvados-DCO-1.1-Signed-off-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/bc146037e1aa617739c0a3859727066c9304829a">bc146037e1aa617739c0a3859727066c9304829a</a> -- <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2696/"<a href="https://ci.arvados.org/view/Developer/job/developer-run-tests/2696/">developer-run-tests: #2696 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2696" alt="" /></a></a></p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971662021-09-20T14:20:01ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Thanks! this LGTM.</p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=971692021-09-20T14:28:04ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados-private:commit:arvados|c8bf4dc1eef2a73b4b01501eabdc922e2a27a276.</p> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=983572021-11-09T20:15:50ZTom Cleggtom@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-3 priority-4 priority-default closed parent" href="/issues/18215">Feature #18215</a>: Use 'select' on collection updates to avoid returning manifest_text</i> added</li></ul> Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responsehttps://dev.arvados.org/issues/18122?journal_id=985962021-11-16T16:34:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>42</i></li></ul>