Project

General

Profile

Actions

Bug #18169

closed

WB2 drag and drop: cancel button not working

Added by Daniel Kutyła 10 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
10/18/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

"When I want to cancel the upload the button is not clickable."


Files


Subtasks 1 (0 open1 closed)

Task #18233: Review 18169-cancel-button-not-workingResolvedDaniel Kutyła10/18/2021

Actions

Related issues

Related to Arvados - Bug #16655: Upload speed indicator shows wrong informationResolvedDaniel Kutyła09/14/2021

Actions
Actions #1

Updated by Peter Amstutz 10 months ago

  • Target version set to 2021-10-13 sprint
Actions #2

Updated by Peter Amstutz 10 months ago

  • Target version changed from 2021-10-13 sprint to 2021-09-29 sprint
Actions #3

Updated by Peter Amstutz 10 months ago

  • Assigned To set to Daniel Kutyła
Actions #4

Updated by Peter Amstutz 10 months ago

  • Related to Bug #16655: Upload speed indicator shows wrong information added
Actions #5

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2021-09-29 sprint to 2021-10-13 sprint
Actions #6

Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
Actions #7

Updated by Daniel Kutyła 9 months ago

  • Status changed from New to In Progress
Actions #8

Updated by Peter Amstutz 9 months ago

  • Target version changed from 2021-10-13 sprint to 2021-10-27 sprint
Actions #9

Updated by Daniel Kutyła 9 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/0fab1ce0739811ff8bc02488d32aa2ad184c7b1e
Test run: developer-tests-workbench2: #499
Branch: 18169-cancel-button-not-working

Removed disable of cancel button when uploading

Actions #10

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2021-10-27 sprint to 2021-11-10 sprint
Actions #11

Updated by Lucas Di Pentima 8 months ago

  • I think it would be beneficial to have some testing for this.
  • When clicking the trashcan button of the item being uploaded, the dialog gets automatically closed. I think this may not be what the user expects, in the case of fixing a mistake. If the user wants to cancel the entire upload task, they could click the CANCEL button.
  • When the dialog is closed because of canceled uploads, there's a "toast" message about "Data has been uploaded." This can be confusing because what happened is the opposite. If the previously commented issue is solved, I think this won't happen.
  • When uploading more than one item, and in the middle of an upload, I cancel the 2nd item, and then the one it's being uploaded, the dialog gets into a state that doesn't get closed, but the upload button shows progress being made. If you wait for it enough, the background upload gets completed but doesn't get reflected on the collection. See attached video for better detail.
Actions #12

Updated by Peter Amstutz 8 months ago

  • Target version changed from 2021-11-10 sprint to 2021-11-24 sprint
Actions #13

Updated by Daniel Kutyła 8 months ago

New version first commit: https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/d8f669aadc5f3d7241395abd6aa764406079d7d3
Test run: developer-tests-workbench2: #512
Branch: 18169-cancel-button-not-working

Applied post review changes, added tests

Actions #15

Updated by Lucas Di Pentima 8 months ago

Some comments:

  • About the cypress tests: I think it would be super helpful that the test waits for the uploads to complete and then confirm that the file is listed on the collection panel; what do you think? Also, on the "cancel a single file" test, ensure that the canceled file isn't listed.
  • Another thought about the tests: Do we need the wait() calls? The assertions already wait for a certain time, and I think if there's a need for an extended assertion wait, it's cleaner to add a timeout to the cy.get() call (https://docs.cypress.io/api/commands/get#Arguments) as we did on loginAs() with cy.url()?
  • The toast issue commented above is still happening.
  • The multi-file uploading & canceling issue mentioned above still is happening. Still, now one of the canceled items gets saved on the collection (see new video) -- I think this could have been detected earlier with a complete test.
Actions #16

Updated by Peter Amstutz 7 months ago

  • Target version changed from 2021-11-24 sprint to 2021-12-08 sprint
Actions #17

Updated by Daniel Kutyła 7 months ago

Actions #18

Updated by Lucas Di Pentima 7 months ago

This LGTM, thanks!

Actions #19

Updated by Daniel Kutyła 7 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
Actions #20

Updated by Lucas Di Pentima 7 months ago

  • Release set to 48
Actions

Also available in: Atom PDF