Arvados

• I think it would be beneficial to have some testing for this.
• When clicking the trashcan button of the item being uploaded, the dialog gets automatically closed. I think this may not be what the user expects, in the case of fixing a mistake. If the user wants to cancel the entire upload task, they could click the CANCEL button.
• When the dialog is closed because of canceled uploads, there's a "toast" message about "Data has been uploaded." This can be confusing because what happened is the opposite. If the previously commented issue is solved, I think this won't happen.
• When uploading more than one item, and in the middle of an upload, I cancel the 2nd item, and then the one it's being uploaded, the dialog gets into a state that doesn't get closed, but the upload button shows progress being made. If you wait for it enough, the background upload gets completed but doesn't get reflected on the collection. See attached video for better detail.

Some comments:

• About the cypress tests: I think it would be super helpful that the test waits for the uploads to complete and then confirm that the file is listed on the collection panel; what do you think? Also, on the "cancel a single file" test, ensure that the canceled file isn't listed.
• Another thought about the tests: Do we need the wait() calls? The assertions already wait for a certain time, and I think if there's a need for an extended assertion wait, it's cleaner to add a timeout to the cy.get() call (https://docs.cypress.io/api/commands/get#Arguments) as we did on loginAs() with cy.url()?
• The toast issue commented above is still happening.
• The multi-file uploading & canceling issue mentioned above still is happening. Still, now one of the canceled items gets saved on the collection (see new video) -- I think this could have been detected earlier with a complete test.

Applied in changeset arvados-workbench-2:arvados-workbench2|6e4b23e9a99ab64e25c60a128e6beb4fa8636374.