https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-09-29T15:17:57ZArvadosArvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=974552021-09-29T15:17:57ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2021-10-13 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=974652021-09-29T15:23:17ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Daniel Kutyła</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=977052021-10-13T15:14:24ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-10-13 sprint</i> to <i>2021-10-27 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=977992021-10-18T15:22:26ZDaniel Kutyła
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=978822021-10-22T12:39:21ZDaniel Kutyła
<ul></ul><p>New version first commit: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/df0c0d462a52003cd722d25520cd7a4ad6583c57">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/df0c0d462a52003cd722d25520cd7a4ad6583c57</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/503"<a href="https://ci.arvados.org/job/developer-tests-workbench2/503/">developer-tests-workbench2: #503 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=503" alt="" /></a></a><br />Branch: 18207-Workbench2-is-not-clearing-the-project-content-when-switching</p>
<p>Project switch should trigger loader</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=980342021-10-27T14:54:02ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-10-27 sprint</i> to <i>2021-11-10 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=983082021-11-08T20:15:13ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>The fix seems to work as expected: the data explorer component immediately shows an "in progress" indicator when changing projects, but I think the code updates make the <code>ProjectPanel</code> component a bit more coupled with external variables and/or state.</p>
<p>We already have an app-wide "in progress" indicator that is being used, and also <code>state.dataExplorer?.projectPanel.items</code> could be reset (or set to <code>undefined</code>?) on every panel change, what do you think? I feel that duplicating the previous query results & browser's href shouldn't be necessary and makes things a little more complicated to manage.</p>
<p>Related to this, the "Shared with me" at the left side bar doesn't seem to be using this new change, this may also be a symptom of needing to fix the problem in a deeper level (at <code>DataExplorer</code>'s level for example) so any part of the app could benefit.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=984112021-11-10T16:10:16ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-11-10 sprint</i> to <i>2021-11-24 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=989772021-11-24T16:56:57ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-11-24 sprint</i> to <i>2021-12-08 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=994552021-12-08T16:08:41ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-12-08 sprint</i> to <i>2022-01-05 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=997522021-12-17T23:26:54ZDaniel Kutyła
<ul></ul><p>New version first commit: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/394ebdfd13fe40a7096f484c46a353d2537f4c9a">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/394ebdfd13fe40a7096f484c46a353d2537f4c9a</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/551"<a href="https://ci.arvados.org/job/developer-tests-workbench2/551/">developer-tests-workbench2: #551 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=551" alt="" /></a></a><br />Branch: 18207-Workbench2-is-not-clearing-the-project-content-when-switching</p>
<p>Merged main</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=997532021-12-20T13:43:45ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>The fix seems to work as expected: the data explorer component immediately shows an "in progress" indicator when changing projects, but I think the code updates make the <code>ProjectPanel</code> component a bit more coupled with external variables and/or state.</p>
<p>We already have an app-wide "in progress" indicator that is being used, and also <code>state.dataExplorer?.projectPanel.items</code> could be reset (or set to <code>undefined</code>?) on every panel change, what do you think? I feel that duplicating the previous query results & browser's href shouldn't be necessary and makes things a little more complicated to manage.</p>
<p>Related to this, the "Shared with me" at the left side bar doesn't seem to be using this new change, this may also be a symptom of needing to fix the problem in a deeper level (at <code>DataExplorer</code>'s level for example) so any part of the app could benefit.</p>
</blockquote>
<p>The updates made in <a class="changeset" title="17585: Project change should trigger loader Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/df0c0d462a52003cd722d25520cd7a4ad6583c57">arvados-workbench2|df0c0d4</a> are just a <code>main</code> merge. Could you explain here why you dismissed my 3 comments? I think it's important for historic reasons that the discussion about the change reasonings is kept in the ticket.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=998942022-01-06T15:51:44ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2022-01-05 sprint</i> to <i>2022-01-19 sprint</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=999762022-01-11T20:39:32ZDaniel Kutyła
<ul></ul><p>I merged this code before going AFK for the longer time, so it can be deployed within the next release as I was asked about this fix. I wrote explaination in the private message to you.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=999772022-01-11T21:13:41ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Daniel Kutyła wrote:</p>
<blockquote>
<p>I merged this code before going AFK for the longer time, so it can be deployed within the next release as I was asked about this fix. I wrote explaination in the private message to you.</p>
</blockquote>
<p>Well, I don't think it's ready to be merged yet, so going AFK isn't enough to make it ready.</p>
<p>As I mentioned <a class="issue tracker-1 status-3 priority-4 priority-default closed parent" title="Bug: Workbench2 is not clearing the project content when switching (Resolved)" href="https://dev.arvados.org/issues/18207#note-7">#18207-7</a> and <a class="issue tracker-1 status-3 priority-4 priority-default closed parent" title="Bug: Workbench2 is not clearing the project content when switching (Resolved)" href="https://dev.arvados.org/issues/18207#note-12">#18207-12</a>, there're still some issues, being one of them another instance of this same bug, maybe you overlooked my comments, or perhaps you decided they aren't worth addressing.</p>
<p>If the latter is the case, please explain the reasons why. We're an open-source project, and we should record all discussions related to it in public because it'll surely be helpful to have the reasons documented for future reference.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=999802022-01-12T13:10:26ZDaniel Kutyła
<ul></ul><p>Hi Lucas<br />I tried to reuse this loader<br />that we use commonly<br />unfortunately it is way to hard<br />because it is triggered by the services<br />and thus it is very unpredictable<br />even though I remove some loaders it is not possible to prevent for new one to happen (because of the ongoing network reuquests)<br />I rebased branch with the newest main<br />so if this is not crucial I would opt for merging this one<br />and maybe we could create a ticket to change the way loader is shown</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=999892022-01-12T17:56:39ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Related to this, the "Shared with me" at the left side bar doesn't seem to be using this new change, this may also be a symptom of needing to fix the problem in a deeper level (at <code>DataExplorer</code>'s level for example) so any part of the app could benefit.</p>
</blockquote>
<p>So how about this? Please make sure the "Shared with me" listing behaves the same way as the rest. As I mentioned on my first comment, the fact that it isn't showing the progress indicator is a clue that there might be code duplication, so it would be great to eliminate that.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000002022-01-13T16:06:43ZDaniel Kutyła
<ul></ul><p>I check shared with me and it seems to be working as other only the main project seems to be not showing the loader but for me it is loading reallyfast that is why loader is not shown</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000012022-01-13T16:13:01ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>File</strong> <a href="/attachments/2933">project-progress-indicator-sharedwithme.mov</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2933/project-progress-indicator-sharedwithme.mov">project-progress-indicator-sharedwithme.mov</a> added</li></ul><p>This is a video created from using your branch against ce8i5, you can see that the "Shared with me" UI doesn't use the new progress indicator.</p>
<p>Personally, I don't like that we have duplicated progress indicators working at the same time, but if we must, at least we should have consistency.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000142022-01-14T15:19:50ZDaniel Kutyła
<ul></ul><p>New version first commit: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/f528cc85e7687e1d899860c4226984bd067c5bd3">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/f528cc85e7687e1d899860c4226984bd067c5bd3</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/560"<a href="https://ci.arvados.org/job/developer-tests-workbench2/560/">developer-tests-workbench2: #560 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=560" alt="" /></a></a><br />Branch: 18207-Workbench2-is-not-clearing-the-project-content-when-switching</p>
<p>Removed duplicated loader to make the UI consistent, but kept the check with 'null' as a value when application is 'working' in order to force React to re-render and thus remove old project contents from the screen</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000152022-01-14T16:04:10ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>For UI consistency, if you want, you could add some images and messages similar to the ones we show on empty projects but notify the user that they should be getting the data soon, as it's being loaded.<br />The 'null' option is acceptable by me, too; I just think it would be nicer to add some content to the blank space.<br />About my previous comment, the UI inconsistency I was referring to is that the "Shared with me" panel doesn't behave the same way as the project panel in the sense that its contents don't get cleared before loading the new data.<br />I've looked at the code, and I think that passing the <code>loading</code> prop to <code>DataExplorer</code> in <code>src/views/shared-with-me-panel/shared-with-me-panel.tsx</code> would do the trick.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000302022-01-18T15:47:24ZDaniel Kutyła
<ul></ul><p>New version first commit: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/89a4eb90454f12be703f711279d0867781013631">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/89a4eb90454f12be703f711279d0867781013631</a><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-tests-workbench2/562"<a href="https://ci.arvados.org/job/developer-tests-workbench2/562/">developer-tests-workbench2: #562 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=562" alt="" /></a></a><br />Branch: 18207-Workbench2-is-not-clearing-the-project-content-when-switching</p>
<p>Added common icon, removed code duplication</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000362022-01-18T17:55:24ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="18207: Makes 'working' status work in 'Shared with me' & 'Groups' DataExplorers Also, replaces t..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/facccf58114be4d8c7a08286cd2197bd222abdc1">arvados-workbench2|facccf58</a></p>
<ul>
<li>The 'Shared with me' issue from <a class="issue tracker-1 status-3 priority-4 priority-default closed parent" title="Bug: Workbench2 is not clearing the project content when switching (Resolved)" href="https://dev.arvados.org/issues/18207#note-19">#18207-19</a> kept existing, and I also detected that the 'Groups' section was suffering from the same problem.</li>
<li>To avoid further back and forth, I took the liberty to fix those, and I also replaced the "folder" icon with another more generic one, as the <code>DataTable</code> component is used not only on project listings, but on other object type listings.</li>
<li>If you agree with the changes, I think this is ready to be merged.</li>
</ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1000872022-01-19T15:56:12ZDaniel Kutyła
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '18207-Workbench2-is-not-clearing-the-project-content-when-switching' into main clos..." href="https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/7f160d39308e02e571543b2958320f387b5372ab">arvados-workbench2|7f160d39308e02e571543b2958320f387b5372ab</a>.</p> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1001482022-01-19T22:05:02ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-4 priority-default closed parent" href="/issues/16951">Bug #16951</a>: Can refresh listing when opening context menu, resulting in wrong item being operated on.</i> added</li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1008032022-02-15T19:02:37ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-4 priority-default closed parent" href="/issues/18769">Bug #18769</a>: Test & confirm no stale data or flickering during data table refreshes</i> added</li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1021592022-03-24T19:59:09ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>46</i></li></ul> Arvados - Bug #18207: Workbench2 is not clearing the project content when switchinghttps://dev.arvados.org/issues/18207?journal_id=1024862022-04-05T18:24:37ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-3 priority-4 priority-default closed parent" href="/issues/18972">Bug #18972</a>: "All processes" view reloading flicker</i> added</li></ul>