Arvados

Updates at arvados-workbench2|91ca19a - branch 18219-props-in-collection-details-panel
Test run: developer-tests-workbench2: #545

• Removes collection's property editor panel.
• Adds collection's property list to the main info panel and also the details panel.
• Allows editing the collection properties from within the details panel, like in projects.
• Removes code duplication related to the property editor dialog.
• Updates tests.

Updates at arvados-workbench2|a589802b
Test run: developer-tests-workbench2: #547

• Fixes the "Warning: React does not recognize the `panelIlluminated` prop on a DOM element." warning messages related to the MultiPanelView components.

This is

Lucas Di Pentima wrote:

Updates at arvados-workbench2|91ca19a - branch 18219-props-in-collection-details-panel
Test run: developer-tests-workbench2: #545

This is a big improvement.

However, there was one thing that I found little confusing. If you are on the collection page, and the info panel is closed, you can't edit the properties. There's no pencil button when the the details are shown in the main panel.

But I also feel like the pencil button is inconsistent with the rest of the details panel which is read-only. All the other changes are done through the command menu.

Can we either (a) add an "Edit Properties" menu item that appears on the context/three dots menu or (b) Remove the separate property editor dialog entirely, and incorporate property editing into the "Edit Project" and "Edit Collection" dialog boxes?

Updates at arvados-workbench2|3836b03c
Test run: developer-tests-workbench2: #554

• Adds properties edition capabilities to project's edit dialog.
• Adds properties edition capabilities to collection's create & edit dialogs.
• Adds tests.

Most of the code changes are about my attempts to reduce the amount of code duplication that was made on the resources' create & edit dialog. Right now we have consistency in terms of collections & projects can be created with properties, and also properties can be seen & edited from the details panel.

Updates at arvados-workbench2|160074ea
Test run: developer-tests-workbench2: #555

• Fixes group management cypress tests.

It seems that the "create group" dialog is another source of code duplication, but not the "group edit" dialog, because the former doesn't include the properties editor, but the latter does (and that was the reason some test failed).

Updates at arvados-workbench2|f6396d36
Test run: developer-tests-workbench2: #556

• Adds property edition capabilities to the group create dialog.

Looks pretty good, two comments:

- It seems awkward to have the pencil button that only edits properties, and only appears in the side panel. I think should do one of:

• Move the pencil up to the top of the details panel, and change it so that it opens the general editing dialog
• OR just get rid of the pencil altogether (because the general editing dialog is already available via right-click menu)

- Both the group and collection edit dialogs feel crowded. I think this can be fixed by some extra padding between the fields, because right now the fields sort of run together.

a couple of clarifications from gitter discussion:

To be consistent, both the group details and collection details should have the edit pencil moved to the top, which should open the general edit dialog. This implies properties-only dialog can go away.

Updates at arvados-workbench2|f024fc6c
Test run: developer-tests-workbench2: #557

• Replaces the property editor dialog with the resource editor dialog on the project & collection details panel.
• Removes unused property editor dialog code.
• Adjusts create/update resource dialog layout adding some vertical space between fields.
• Fixes tests.

Lucas Di Pentima wrote:

Updates at arvados-workbench2|f024fc6c
Test run: developer-tests-workbench2: #557

• Replaces the property editor dialog with the resource editor dialog on the project & collection details panel.
• Removes unused property editor dialog code.
• Adjusts create/update resource dialog layout adding some vertical space between fields.
• Fixes tests.

This LGTM, thanks!

Lucas Di Pentima wrote:

Updates at arvados-workbench2|15b6918 - branch 18219-edit-btn-styling

As requested in the last demo, I've improved the edit button styling following the existing app's style to make it clearer that it is a button.
Screenshot attached for easy reviewing.

LGTM, thanks!

Lucas Di Pentima wrote:

Updates at arvados-workbench2|4c3a13a - branch 18219-prop-chips-styling

• Makes the property chips list to use the complete horizontal space without regards of the twoCol prop setting.
• Fixes chip spacing in the collection's detail panel.

Attached screen captures for easy comparison.

yep, that's perfect, exactly what I was hoping for. LGTM