Project

General

Profile

Actions
Copy link

Bug #18247

closed

[arv] faraday gem warnings on Ruby 2.7+

Added by Ward Vandewege over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Ward Vandewege
Category:
-
Target version:
2021-10-13 sprint
Story points:
-
Release:
Arvados 2.3.0
Release relationship:
Auto

Description

e.g. on Ubuntu 20.04 (Focal Fossa) with system Ruby packages:

$ arv
/var/lib/gems/2.7.0/gems/faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/var/lib/gems/2.7.0/gems/faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/var/lib/gems/2.7.0/gems/faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/var/lib/gems/2.7.0/gems/faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
/var/lib/gems/2.7.0/gems/faraday-0.15.4/lib/faraday/options.rb:166: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
ARVADOS_API_HOST and ARVADOS_API_TOKEN need to be defined as environment variables.
$ ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux-gnu]
$ gem list |grep arv
arvados (2.2.2)
arvados-cli (2.2.2)
arvados-google-api-client (0.8.7.4)

Subtasks 1 (0 open — 1 closed)

Task #18250: review 18247-faraday-versionResolvedWard Vandewege10/05/2021Actions

Related issues

Related to Arvados - Bug #15673: [SDKs][Ruby] Update faraday usageResolvedTom CleggActions
Related to Arvados - Bug #18309: [gem] faraday dependency difference between arvados and arvados-login-syncResolvedWard Vandewege10/29/2021Actions
Actions
Copy link
 #1

Updated by Ward Vandewege over 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Ward Vandewege over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Ward Vandewege over 2 years ago

  • Release set to 42
Actions
Copy link
 #4

Updated by Ward Vandewege over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Ward Vandewege over 2 years ago

Hmm. We have faraday 0.15.4 because of the old arvados-google-api-client gem we use, according to a comment in arvados-cli.gemspec:

  # arvados-google-api-client 0.8.7.2 is incompatible with faraday 0.16.2
  s.add_dependency('faraday', '< 0.16')

This was done in #15673, where we also pushed 0.8.7.3 for arvados-google-api-client. So.... the logical solution then may be to depend on that version of arvados-google-api-client and remove this faraday pin. Maybe. Looking into that...

Actions
Copy link
 #6

Updated by Ward Vandewege over 2 years ago

  • Related to Bug #15673: [SDKs][Ruby] Update faraday usage added
Actions
Copy link
 #7

Updated by Ward Vandewege over 2 years ago

Ready for review in ebf9bc1e9ac39c4c0b4ea36fd3bd5d9411c73a6b on branch 18247-faraday-version

Actions
Copy link
 #8

Updated by Lucas Di Pentima over 2 years ago

Running tests at: developer-run-tests: #2724

Actions
Copy link
 #9

Updated by Lucas Di Pentima over 2 years ago

Test passed - LGTM!

Actions
Copy link
 #10

Updated by Ward Vandewege over 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #11

Updated by Ward Vandewege over 2 years ago

  • Related to Bug #18309: [gem] faraday dependency difference between arvados and arvados-login-sync added
Actions
Copy link

Also available in: Atom PDF