Bug #18284

VM listing buggy in workbench2

Added by Peter Amstutz 7 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Start date:
01/27/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

As an admin on pirca (running 2.3.0~rc3)

  • The "user" VM list is empty (it should show the vms I can log in to)
  • The "admin" VM list only shows on the vm that I can log in to and not anyone else's login permissions

The user list should show the VMs I can log in to, with the webshell button.

The admin list should show all VMs and login permissions associated with those VMs, and let me add or remove login permissions.


Subtasks

Task #18478: Review 18284-vm-listingResolvedPeter Amstutz

Associated revisions

Revision 5e805cf2
Added by Stephen Smith 3 months ago

Merge branch '18284-vm-listing' into main. Closes #18284

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <>

History

#1 Updated by Peter Amstutz 7 months ago

  • Category set to Workbench2
  • Description updated (diff)

#2 Updated by Peter Amstutz 7 months ago

  • Release set to 45

#3 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2021-10-27 sprint to 2021-11-10 sprint

#4 Updated by Peter Amstutz 7 months ago

  • Target version changed from 2021-11-10 sprint to 2021-11-24 sprint

#5 Updated by Peter Amstutz 6 months ago

  • Target version changed from 2021-11-24 sprint to 2021-12-08 sprint

#6 Updated by Peter Amstutz 6 months ago

  • Release deleted (45)

#7 Updated by Peter Amstutz 6 months ago

  • Assigned To set to Stephen Smith

#8 Updated by Stephen Smith 6 months ago

  • Status changed from New to In Progress

#9 Updated by Peter Amstutz 6 months ago

  • Target version changed from 2021-12-08 sprint to 2022-01-05 sprint

#10 Updated by Peter Amstutz 5 months ago

  • Target version changed from 2022-01-05 sprint to 2022-01-19 sprint

#11 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-01-19 sprint to 2022-02-02 sprint

#12 Updated by Stephen Smith 4 months ago

Changes at arvados-workbench2|281300c86c615248d124c8b5bb6b7a3461b63349 branch 18284-vm-listing
Tests: developer-tests-workbench2: #567

  • Fixed display bugs to show correct vms and logins on user/admin pages
  • Added create login dialog and remove login button on admin page
    • Logins are created with the same username as the user
    • Default group list is ['docker']
  • Added list of groups on user vm page
  • Added icon to vm admin breadcrumb

#13 Updated by Peter Amstutz 4 months ago

18284-vm-listing @ commit:281300c86c615248d124c8b5bb6b7a3461b63349

Admin VM panel

  • Having default groups hardcoded into workbench seems like a bad idea. We could put something in the configuration but that's a bit of extra work, so let's just have it start empty.
    • The label could say something like "for example: docker, sudo"
  • It's a little awkward and not obvious that you supposed to hit enter after typing the name of each group
  • I crashed the app:
    1. Typed in "docker, sudo" for the groups
    2. Did not hit enter
    3. then hit "Add"
    4. crash screen with "TypeError: values.map is not a function"
  • Similarly, if I type in "docker, sudo" and hit enter, I get a group called "docker, sudo" and not two groups
  • It should split on at least commas and spaces, maybe also colons, semicolons, and reject most other punctuation (check what's legal for unix group names).
  • As an admin, I can't easily see or edit the unix groups for a user. Could you make it so that clicking on a chip opens an "Update login permission" dialog so I can view or edit that specific login, with an "Update" button to save it?

User VM panel

  • Can we have a "copy to clipboard" button next to each entry in the "Command line" column?
  • Can you tweak the styling so that "Log in as XYZ" looks like a button and not a hyperlink

#14 Updated by Peter Amstutz 4 months ago

  • Target version changed from 2022-02-02 sprint to 2022-02-16 sprint

#15 Updated by Peter Amstutz 4 months ago

  • Release set to 46

#16 Updated by Stephen Smith 3 months ago

Changes at arvados-workbench2|87ba49100005ac43690cd2f77b2f797154998d01
Tests developer-tests-workbench2: #581

  • Added regex-based tokenization option for chips-input
  • Added update login dialog
  • Remove default groups and add hint text ("eg. docker, sudo")
  • Fix chips error by removing extraneous onblur handler
  • Add copy button to user vm ssh command
  • Change webshell "log in as" link to button styling

#17 Updated by Peter Amstutz 3 months ago

Stephen Smith wrote:

Changes at arvados-workbench2|87ba49100005ac43690cd2f77b2f797154998d01
Tests developer-tests-workbench2: #581

  • Added regex-based tokenization option for chips-input
  • Added update login dialog
  • Remove default groups and add hint text ("eg. docker, sudo")
  • Fix chips error by removing extraneous onblur handler
  • Add copy button to user vm ssh command
  • Change webshell "log in as" link to button styling

This is really good! LGTM

#18 Updated by Stephen Smith 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF