Story #18287

Remove superfluous ExternalURL: "-" entries from config template/defaults file

Added by Tom Clegg 7 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
2021-10-27 sprint
Start date:
10/22/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.4.0
Release relationship:
Auto

Subtasks

Task #18291: Review 18287-external-url-defaultsIn ProgressTom Clegg

History

#1 Updated by Tom Clegg 7 months ago

  • Status changed from New to In Progress

#2 Updated by Tom Clegg 7 months ago

AFAICT the "-" entries were added in #15003 with intent to indicate "ExternalURL is not needed" (as opposed to "...not configured yet"), but the config-load/check don't warn about missing entries anyway, and if/when we do add such warnings, we can arrange to not warn about the services that don't need external URLs. So all the "-" entries really seem to do is create an unnecessary mystery for a person editing a config file.

18287-external-url-defaults @ 0bfda57681195c431e3b6063577fdab23ff40cd5 -- developer-run-tests: #2736

#3 Updated by Lucas Di Pentima 7 months ago

This LGTM, thanks.

#4 Updated by Tom Clegg 7 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|125dd3b1e5f34156b002951f504f5346cc5d7e8d.

#5 Updated by Peter Amstutz 2 months ago

  • Release set to 46

Also available in: Atom PDF