Project

General

Profile

Actions

Idea #18287

closed

Remove superfluous ExternalURL: "-" entries from config template/defaults file

Added by Tom Clegg over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (1 open0 closed)

Task #18291: Review 18287-external-url-defaultsIn ProgressTom Clegg10/22/2021Actions
Actions #1

Updated by Tom Clegg over 2 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Tom Clegg over 2 years ago

AFAICT the "-" entries were added in #15003 with intent to indicate "ExternalURL is not needed" (as opposed to "...not configured yet"), but the config-load/check don't warn about missing entries anyway, and if/when we do add such warnings, we can arrange to not warn about the services that don't need external URLs. So all the "-" entries really seem to do is create an unnecessary mystery for a person editing a config file.

18287-external-url-defaults @ 0bfda57681195c431e3b6063577fdab23ff40cd5 -- developer-run-tests: #2736

Actions #3

Updated by Lucas Di Pentima over 2 years ago

This LGTM, thanks.

Actions #4

Updated by Tom Clegg over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Applied in changeset arvados-private:commit:arvados|125dd3b1e5f34156b002951f504f5346cc5d7e8d.

Actions #5

Updated by Peter Amstutz almost 2 years ago

  • Release set to 46
Actions

Also available in: Atom PDF