https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422021-10-27T14:49:35ZArvadosArvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=980002021-10-27T14:49:35ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-11-10 sprint</i> to <i>2021-11-24 sprint</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=983552021-11-09T20:12:50ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-11-24 sprint</i> to <i>2021-12-08 sprint</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=989132021-11-23T21:13:34ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Category</strong> set to <i>Workbench</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=989832021-11-24T16:58:21ZTom Cleggtom@curii.com
<ul></ul><p>Not sure if this is the same problem, but the error I ran into was "can't update mounts when state is Final" (not exact wording) when trying to cancel a container that was in Locked state.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=989992021-11-24T17:06:51ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Lucas Di Pentima</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=990212021-11-24T21:39:17ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=991342021-11-30T20:01:58ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>I'm not able to reproduce the issue, please provide a specific case.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=992382021-12-03T15:15:32ZWard Vandewegeward@curii.com
<ul></ul><p>On Pirca, trying to move <a class="external" href="https://workbench.pirca.arvadosapi.com/container_requests/pirca-xvhdp-om4zxfsae65h29f#Log">https://workbench.pirca.arvadosapi.com/container_requests/pirca-xvhdp-om4zxfsae65h29f#Log</a> into a project, I get:</p>
<pre>
//railsapi.internal/arvados/v1/container_requests/pirca-xvhdp-om4zxfsae65h29f: 422 Unprocessable Entity: Mounts cannot be modified in state 'Final' ({"/keep/bcca5ee5b64d1f30296f204be49fc050+270"=>{"kind"=>"collection", "portable_data_hash"=>"bcca5ee5b64d1f30296f204be49fc050+270"}, "/tmp"=>{"capacity"=>1073741824, "kind"=>"tmp"}, "/var/spool/cwl"=>{"capacity"=>1073741824, "kind"=>"tmp"}}, {"/keep/bcca5ee5b64d1f30296f204be49fc050+270"=>{"capacity"=>0, "commit"=>"", "content"=>nil, "device_type"=>"", "exclude_from_output"=>false, "git_url"=>"", "kind"=>"collection", "path"=>"", "portable_data_hash"=>"bcca5ee5b64d1f30296f204be49fc050+270", "repository_name"=>"", "uuid"=>"", "writable"=>false}, "/tmp"=>{"capacity"=>1073741824, "commit"=>"", "content"=>nil, "device_type"=>"", "exclude_from_output"=>false, "git_url"=>"", "kind"=>"tmp", "path"=>"", "portable_data_hash"=>"", "repository_name"=>"", "uuid"=>"", "writable"=>false}, "/var/spool/cwl"=>{"capacity"=>1073741824, "commit"=>"", "content"=>nil, "device_type"=>"", "exclude_from_output"=>false, "git_url"=>"", "kind"=>"tmp", "path"=>"", "portable_data_hash"=>"", "repository_name"=>"", "uuid"=>"", "writable"=>false}}) (req-evc322zkn8hjjscktltz)
</pre> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=992822021-12-03T16:52:53ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>It seems that controller is passing empty (zero-value) fields and that's why the validation fails:</p>
<a name="Previous-state"></a>
<h4 >Previous state<a href="#Previous-state" class="wiki-anchor">¶</a></h4>
<pre>
{
"/keep/bcca5ee5b64d1f30296f204be49fc050+270"=>{
"kind"=>"collection",
"portable_data_hash"=>"bcca5ee5b64d1f30296f204be49fc050+270"
},
"/tmp"=>{
"capacity"=>1073741824,
"kind"=>"tmp"
},
"/var/spool/cwl"=>{
"capacity"=>1073741824,
"kind"=>"tmp"
}
}
</pre>
<a name="New-state"></a>
<h4 >New state<a href="#New-state" class="wiki-anchor">¶</a></h4>
<pre>
{
"/keep/bcca5ee5b64d1f30296f204be49fc050+270"=>{
"capacity"=>0,
"commit"=>"",
"content"=>nil,
"device_type"=>"",
"exclude_from_output"=>false,
"git_url"=>"",
"kind"=>"collection",
"path"=>"",
"portable_data_hash"=>"bcca5ee5b64d1f30296f204be49fc050+270",
"repository_name"=>"",
"uuid"=>"",
"writable"=>false
},
"/tmp"=>{
"capacity"=>1073741824,
"commit"=>"",
"content"=>nil,
"device_type"=>"",
"exclude_from_output"=>false,
"git_url"=>"",
"kind"=>"tmp",
"path"=>"",
"portable_data_hash"=>"",
"repository_name"=>"",
"uuid"=>"",
"writable"=>false
},
"/var/spool/cwl"=>{
"capacity"=>1073741824,
"commit"=>"",
"content"=>nil,
"device_type"=>"",
"exclude_from_output"=>false,
"git_url"=>"",
"kind"=>"tmp",
"path"=>"",
"portable_data_hash"=>"",
"repository_name"=>"",
"uuid"=>"",
"writable"=>false
}
}
</pre> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=993202021-12-06T14:30:36ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Update: I've kept trying to reproduce the issue and found something interesting: I was able to get the error when attempting to move a CR on pirca (v2.3.1~rc3), but when doing so on ce8i5 or tordo (both v2.4.0~dev) or even jutro (v2.2.1), they worked just fine.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=993692021-12-07T14:33:40ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Status update: While trying to reproduce the issue on local arvbox instances running different arvados versions, I realized that the failure isn't related to the version as previously thought, but the bug is triggered by some other reason. Example:</p>
<ul>
<li>Container request <a href="https://arvadosapi.com/ce8i5-xvhdp-haiyk7xqphcjf4u">ce8i5-xvhdp-haiyk7xqphcjf4u</a> doesn't have any issues with being moved.</li>
<li>Container request <a href="https://arvadosapi.com/ce8i5-xvhdp-pk34kuh6ghs8qvm">ce8i5-xvhdp-pk34kuh6ghs8qvm</a> cannot be moved, giving a similar error that the one described on this ticket.</li>
</ul>
<p>Both CRs have a read-only collection-type mount and several temp mounts.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=993752021-12-07T15:53:18ZTom Cleggtom@curii.com
<ul></ul><p>services/api/app/models/container_request.rb</p>
<pre>
def check_update_whitelist
...
elsif mounts_changed? && mounts_was.keys == mounts.keys
...
</pre>
<p>This looks like it's unintentionally sensitive to key order. Perhaps the outcome is different when, while reformatting the get/list response, controller sorts the keys differently than the program that created (or most recently updated) the record?</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=993862021-12-07T17:35:40ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>The ordering didn't seem to be a problem (although I think it won't hurt to <code>.sort()</code> the keys list for comparison), but I think I've found what's the problem: The code from <code>check_update_whitelist</code> doesn't take 0 (zero) as one of the zero-values.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=993872021-12-07T18:16:04ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="18301: Fixes the issue by adding 0 as one of the default values to be ignored. Also, pre-sort mo..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/1f626bc3482d258dc16f4e972b0008a7da7d7bbd">1f626bc34</a> - branch <code>18301-wb1-cancel-button-fix</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2831/"<a href="https://ci.arvados.org/job/developer-run-tests/2831/">developer-run-tests: #2831 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2831" alt="" /></a></a></p>
<ul>
<li>Adds <code>0</code> (zero) as one of the default values that needs to be ignored when validating changes on mounts.</li>
<li>Adds test case.</li>
</ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=994492021-12-08T14:00:58ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Target version</strong> changed from <i>2021-12-08 sprint</i> to <i>2022-01-05 sprint</i></li></ul> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=996712021-12-15T21:23:42ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Updates at <a class="changeset" title="18301: Fixes the issue by adding 0 as one of the default values to be ignored. Also, pre-sort mo..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/1f626bc3482d258dc16f4e972b0008a7da7d7bbd">1f626bc34</a> - branch <code>18301-wb1-cancel-button-fix</code><br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/2831/"<a href="https://ci.arvados.org/job/developer-run-tests/2831/">developer-run-tests: #2831 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=2831" alt="" /></a></a></p>
<ul>
<li>Adds <code>0</code> (zero) as one of the default values that needs to be ignored when validating changes on mounts.</li>
<li>Adds test case.</li>
</ul>
</blockquote>
<p>This LGTM</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=996732021-12-15T21:32:42ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados-private:commit:arvados|2f344e8b8dde661e74307ed7e561a758809382e1.</p> Arvados - Bug #18301: WB1 cancel button not workinghttps://dev.arvados.org/issues/18301?journal_id=1021142022-03-24T19:28:21ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>46</i></li></ul>